From: "Elias Oltmanns" <oltmanns@uni-bonn.de>
To: linux-kernel@vger.kernel.org, ftdi-usb-sio-devel@sourceforge.net
Subject: patch - ftdi_sio.c floods my logs with "write request of 0 bytes"
Date: Sat, 29 Jan 2005 19:14:18 +0000 [thread overview]
Message-ID: <873bwkcak5.fsf@denkblock.local> (raw)
Hi there,
unfortunately, I'm everything else but a developer, so please be a bit
patient with me.
As indicated by the subject, I got annoyed by the error message
mentioned flooding my log files. Comparing ftdi_sio.c to some of the
other usb->serial converter drivers, I decided to apply the following
small patch:
________
--- linux-2.6.10.orig/drivers/usb/serial/ftdi_sio.c 2004-12-24 21:35:24.000000000 +0000
+++ linux-2.6.10/drivers/usb/serial/ftdi_sio.c 2005-01-29 17:10:11.000000000 +0000
@@ -1518,7 +1518,7 @@
dbg("%s port %d, %d bytes", __FUNCTION__, port->number, count);
if (count == 0) {
- err("write request of 0 bytes");
+ dbg("%s - write request of 0 bytes", __FUNCTION__);
return 0;
}
________
It solved my problem but I can't judge, of course, whether the use of
err() instead of dbg() is justified or even common in this place, as,
for instance, ftdi_sio.c is considered experimental. Therefore I would
be grateful to get a short response.
Thank you very much in advance,
Elias
reply other threads:[~2005-01-29 19:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873bwkcak5.fsf@denkblock.local \
--to=oltmanns@uni-bonn.de \
--cc=ftdi-usb-sio-devel@sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox