From: Dave <dave.jiang@gmail.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org, smaurer@teja.com,
linux@arm.linux.org.uk, dsaxena@plexity.net,
drew.moseley@intel.com
Subject: Re: clean way to support >32bit addr on 32bit CPU
Date: Tue, 11 Jan 2005 12:40:31 -0700 [thread overview]
Message-ID: <8746466a0501111140194fbc7f@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0501101607240.2373@ppc970.osdl.org>
On Mon, 10 Jan 2005 16:09:57 -0800 (PST), Linus Torvalds
<torvalds@osdl.org> wrote:
>
>
> On Mon, 10 Jan 2005, Dave wrote:
> >
> > After all said and done, the struct resource members start and end
> > must support 64bit integer values in order to work. On a 64bit arch
> > that would be fine since unsigned long is 64bit. However on a 32bit
> > arch one must use unsigned long long to get 64bit.
>
> We really should make "struct resource" use u64's. It's wrong even on x86,
> but we've never seen any real problems in practice, so we've had little
> reason to bother.
>
> This has definitely come up before, maybe there's even some old patch
> floating around. It should be as easy as just fixing up "start/end" to be
> "u64" (and perhaps move them to the beginning of the struct to make sure
> packing is ok on all architectures), and fixing any fall-out.
>
> Linus
>
Shall I change the PCI resource stuff also to be u64 or leave that
alone? Currently I think we assume on 32bit processors all PCI
resources are in the first 4GB region. Just wondering if that should
be left alone....
--
-= Dave =-
Software Engineer - Advanced Development Engineering Team
Storage Component Division - Intel Corp.
mailto://dave.jiang @ intel
http://sourceforge.net/projects/xscaleiop/
----
The views expressed in this email are
mine alone and do not necessarily
reflect the views of my employer
(Intel Corp.).
prev parent reply other threads:[~2005-01-11 19:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-10 23:34 clean way to support >32bit addr on 32bit CPU Dave
2005-01-11 0:01 ` Slade Maurer
2005-01-11 0:00 ` Deepak Saxena
2005-01-11 0:35 ` Slade Maurer
2005-01-11 0:04 ` Roland Dreier
2005-01-11 0:09 ` Linus Torvalds
2005-01-11 0:28 ` Randy.Dunlap
2005-01-11 1:30 ` Linus Torvalds
2005-01-11 2:05 ` William Lee Irwin III
2005-01-11 3:38 ` Randy.Dunlap
2005-01-11 17:39 ` Randy.Dunlap
2005-01-11 18:18 ` Linus Torvalds
2005-01-11 19:40 ` Dave [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8746466a0501111140194fbc7f@mail.gmail.com \
--to=dave.jiang@gmail.com \
--cc=drew.moseley@intel.com \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=smaurer@teja.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox