Re: [PATCH 1/5] Convert resource to u64 from unsigned long

Linus Torvalds
2005-01-14T00:44:26Z

On Thu, 13 Jan 2005, Andrew Morton wrote:
>
> Also, the patches introduce tons of ifdefs such as:
>
> +#if BITS_PER_LONG == 64
> return (void __iomem *)pci_resource_start(pdev, PCI_ROM_RESOURCE);
> +#else
> + return (void __iomem *)(u32)pci_resource_start(pdev, PCI_ROM_RESOURCE);
> +#endif

Ouch. Who does that, anyway? It's wrong to do that. It's not a pointer,
not even an __iomem one. You'd need to do an ioremap() on it to turn it
into a pointer.

Linus