From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CF67284B26 for ; Wed, 28 Jan 2026 08:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769588365; cv=none; b=Xl00UL4jga2f0E74Ijhpl5JAGegHVOtB4A+eLBfs5gTPzv14LDP/WWJKeN2n7WFKp7gwcBUfVLHXRBOqGjlE2UljbI4xvN38pZVz1yztUjyt4C1iRZXRlWPzl8GS3F/aY8hcSZN5G1rluSRHMVIyGSA2gvzlZXuaV6BAlRNb8mQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769588365; c=relaxed/simple; bh=I3RR4mkzvl3vrE7xdB+EXcNPHaVK9jeMfWJtpB2Cb/A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sPPOLcaUmMC2SYscqBkDGkK8V91Ciomao1+SP/wuFBfQgOzfF5xvUM/e+nPZhgfR2M+KEgol4CgQsHhEFTCE5OBUitt8B0+TEtyPHoWnJaGh3b92fbbZK9Tj7+CSFXBa0mZHvTinINvrSdeWoWHah++nz7MN/+dpePpmfRG7Sr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YektZVu0; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YektZVu0" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-bc17d39ccd2so2307995a12.3 for ; Wed, 28 Jan 2026 00:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769588364; x=1770193164; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=syby8oeFyZiDA53Kg1ApA4RRxVSYxXfIUH/FGHxf7A4=; b=YektZVu06aPh2N57E9Reg7Bg5oXylj8Cs/Ww/9s/CT+T6rVCNDqF43ogxGpcIAzcsD UhTb7+HLeLnZ08xeyCEIZoukDhPhkpoEhT3bgfR8nqGRGPaHzI9ryqQ6Y09OyXEC+TgU +FWz5K/tA5lmQqSoJ7vjKmFzeWViN2rhQjPwfPSFDi1h353cOYQg8ZF82rBh6X6hW9LA xWkiAmKgflCRHG8dCinaF3nYtJiAZrVMqZhClbhFPgWW+XzYQ51sBrxQsZ9lH2UaRTnG naowKAMfrFkUnAo5UmI1+nTPCeTSmkTmznzXHlfg0FwqNnu62+h53G627UDTKXsn1d83 KaGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769588364; x=1770193164; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=syby8oeFyZiDA53Kg1ApA4RRxVSYxXfIUH/FGHxf7A4=; b=gRQlRFS1vvggQGKONwJv3TgpwU3V4dUqQg35wryDqr+m0mAIVJba7RUUmssvLbs2aI bxD+YomMcHK57qW2oWNPos1bhQxWrqHmPDyII4KTn08C3WoJ3T4SS12LFLk9l7YfdTew EgZZ7GVbU2TBstkACobFS63A4AH9TvwTTpBAr2JoCmUJPjEAdKP9v5BtIa4zxRIXbanl TbpqQL2RX8Sq7lFeWRGRl1k4bi01dy8no913fbKSiEl4tMT8I4EhX8M2gvw9yHCQ9dOI AWEuNoN/eOMkCXD3QEQ6Bvowi0N5hhqmIsz9M6OcGFi9ph8+ra+Thzr+Ew+7jHDYbUjz ZgQg== X-Forwarded-Encrypted: i=1; AJvYcCXAIO3ggvpSuQsdka9W/BxkGmykIBkYbhe+ZiN9gSKwY7V81g4CqppJQPbuKE08k13v/Of2d1MOgzQeV7s=@vger.kernel.org X-Gm-Message-State: AOJu0YxwAsjOJGjgUKP4mfXsOuWWAJdJkqeo4/UTNdr6N+2j6t+Rc3sS gKJnLtfw/0m7sOtZKpN/HyWcJavV/MaQGBPoR6pwbBwuPSFIg1UFHBKL X-Gm-Gg: AZuq6aLhyVWKWn1k+a/l5EBlOHyN7+mvaBBEIwk8L5/5SfWx1fwCINLAvm7JJQWfBI2 n9qrRRw0/nW/tBWhCUSXyuFID4+MDxjOCt9xVjY87tk9Uzc1HSLPcvic7vJ2kMLVHouL6g751xC rQcueImPLE2x0gmVA9aCfFxjM1MlbqlNZs+LV00umfSuKtwUMjcW46vaz2ZUe8oz27RXiqiHMLU n5vBg3kE4KjjmWF6Rdw8gB6J0Q/bdj06aa6+7wlo4jps4JsdimhEabbHnk2O0XaxCfSbgFm8610 aGTElQkOaCuo7SVP2YXEj/AhxFoIxR7reFO2FRoCMnTqr6JJQLPBYYuuC7Pv0J9HwOPcwWNTPYd znOUYcmYwuuUvL4cAs10wbwWF6jjd76bGklcfEP21keUmw6OlF3H7ccY3K5rG/aA3DYuDn4yxMv EBzxVYyWcImLFLJ7Oyj74= X-Received: by 2002:a17:90a:e183:b0:34c:37b8:db34 with SMTP id 98e67ed59e1d1-353fedb153fmr3633477a91.32.1769588363583; Wed, 28 Jan 2026 00:19:23 -0800 (PST) Received: from [0.0.0.0] ([188.253.4.252]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3540f17955asm1664437a91.0.2026.01.28.00.19.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 00:19:23 -0800 (PST) Message-ID: <874829ba-00b9-49cd-8f67-a4c33a8f409f@gmail.com> Date: Wed, 28 Jan 2026 16:19:14 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf callchain: Fix suspicious RCU usage in get_callchain_entry() To: Qing Wang , andrii.nakryiko@gmail.com Cc: acme@kernel.org, adrian.hunter@intel.com, alexander.shishkin@linux.intel.com, bpf@vger.kernel.org, irogers@google.com, jolsa@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, radoslaw.zielonek@gmail.com, syzbot+72a43cdb78469f7fbad1@syzkaller.appspotmail.com References: <20260128062656.1860201-1-wangqing7171@gmail.com> From: Tao Chen In-Reply-To: <20260128062656.1860201-1-wangqing7171@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/1/28 14:26, Qing Wang 写道: > On Fri, 19 Jul 2024 at 01:41, Andrii Nakryiko wrote: >> Which is what I'm doing in [0]. Radoslaw, can you please help >> validating if those changes are enough to fix this issue or we need to >> do some more? >> >> [0] https://patchwork.kernel.org/project/netdevbpf/patch/20240709204245.3= >> 847811-10-andrii@kernel.org/ >> >>> >>>> --- >>>> kernel/events/callchain.c | 11 +++++++++-- >>>> 1 file changed, 9 insertions(+), 2 deletions(-) >>>> > > Hi, > > I found this issue still exists after your patch in upstream and I have a > patch to fix it. > > Patch here: https://lore.kernel.org/all/20260128061753.1857803-1-wangqing7171@gmail.com/T/ > > Looking forward to your review. > > -- > Best regards, > Qing > Hi Qing, I have a change that will remove RCU. As Andrii pointed out, using get_callchain_entry without RCU lock in BPF appears to be safe for now. Please point out if I've missed anything. https://lore.kernel.org/bpf/fb745675-e25c-4dcc-be4b-4a4411056755@linux.dev/T/#mc0fc5e0fec2e6456f72f402308fd4e397ba19d09 -- Best Regards Tao Chen