The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Fushuai Wang <fushuai.wang@linux.dev>,
	gregkh@linuxfoundation.org, jirislaby@kernel.org,
	osama.abdelkader@gmail.com, jackzxcui1989@163.com,
	asrinivasan@oss.tenstorrent.com, andy.shevchenko@gmail.com,
	broonie@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Fushuai Wang <wangfushuai@baidu.com>
Subject: Re: [PATCH] Revert "serial: 8250: Clear CON_PRINTBUFFER on port re-registration"
Date: Fri, 24 Jul 2026 10:38:02 +0206	[thread overview]
Message-ID: <874ihookjh.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20260724072452.40455-1-fushuai.wang@linux.dev>

On 2026-07-24, Fushuai Wang <fushuai.wang@linux.dev> wrote:
> From: Fushuai Wang <wangfushuai@baidu.com>
>
> This reverts commit d338ab1d90603f875c4f7ed223406535378173a5.
>
> This may cause some boot logs to be lost on some platforms.
>
> Reported-by: Mark Brown <broonie@kernel.org>
> Reported-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
> Link: https://lore.kernel.org/all/20260522101042.21976-1-fushuai.wang@linux.dev/
> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>

Reviewed-by: John Ogness <john.ogness@linutronix.de>

I also recently stumbled on commmit d338ab1d9060 ("serial: 8250: Clear
CON_PRINTBUFFER on port re-registration") and was surprised to see it
was accepted.

If the double-printing is happening for certain cases with 8250_pnp, I
would expect 8250_pnp (not 8250_core) to detect and handle that
case. 8250_core is the base for a lot of 8250 variants.

John Ogness

  reply	other threads:[~2026-07-24  8:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  7:24 [PATCH] Revert "serial: 8250: Clear CON_PRINTBUFFER on port re-registration" Fushuai Wang
2026-07-24  8:32 ` John Ogness [this message]
2026-07-24  8:36 ` Greg KH
2026-07-24  9:01   ` John Ogness
2026-07-24 11:21   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ihookjh.fsf@jogness.linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=andy.shevchenko@gmail.com \
    --cc=asrinivasan@oss.tenstorrent.com \
    --cc=broonie@kernel.org \
    --cc=fushuai.wang@linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=jackzxcui1989@163.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=osama.abdelkader@gmail.com \
    --cc=wangfushuai@baidu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox