From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Michael Walle <mwalle@kernel.org>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Takahiro Kuwano <takahiro.kuwano@infineon.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
linux-mtd@lists.infradead.org,
Cheng Ming Lin <chengminglin@mxic.com.tw>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 7/8] mtd: spi-nor: push the rollback mechanism into the sfdp module
Date: Mon, 06 Jul 2026 16:22:05 +0200 [thread overview]
Message-ID: <874iickxki.fsf@bootlin.com> (raw)
In-Reply-To: <20260703143003.1809579-8-mwalle@kernel.org> (Michael Walle's message of "Fri, 3 Jul 2026 16:29:18 +0200")
On 03/07/2026 at 16:29:18 +02, Michael Walle <mwalle@kernel.org> wrote:
> Right now, the core is handling the rollback of the parameters. But it
> doesn't have the knowledge what has to be rolled back. And in fact,
> havent rolled back everything. Push it down to the called function and
> make it mandatory, that this function has no side effects if it fails.
>
> Funny enough, there is a comment in the SFDP table handing code that
handling? ^
> each table parser is responsible to roll back any changes. But none of
> them did. So while add it, expand the logic to that and roll it back for
> them. There is one simple rule though:
>
> SFDP parsing and fixups may only modify the spi_nor_flash_parameters.
Ok.
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
next prev parent reply other threads:[~2026-07-06 14:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 14:29 [PATCH v1 0/8] mtd: spi-nor: Rework flash parameter initialization Michael Walle
2026-07-03 14:29 ` [PATCH v1 1/8] mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag Michael Walle
2026-07-03 14:29 ` [PATCH v1 2/8] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure Michael Walle
2026-07-03 14:29 ` [PATCH v1 3/8] mtd: spi-nor: move cmd_ext_type into spi_nor_flash_parameter Michael Walle
2026-07-03 14:29 ` [PATCH v1 4/8] mtd: spi-nor: move flags " Michael Walle
2026-07-03 14:29 ` [PATCH v1 5/8] mtd: spi-nor: move spi_nor_post_bfpt_fixups() into sfdp Michael Walle
2026-07-06 14:18 ` Miquel Raynal
2026-07-03 14:29 ` [PATCH v1 6/8] mtd: spi-nor: spansion: s25fs256t: move ARCFN check into .late_init Michael Walle
2026-07-03 14:29 ` [PATCH v1 7/8] mtd: spi-nor: push the rollback mechanism into the sfdp module Michael Walle
2026-07-06 14:22 ` Miquel Raynal [this message]
2026-07-06 14:34 ` Michael Walle
2026-07-03 14:29 ` [PATCH v1 8/8] mtd: spi-nor: rework flash parameter initialization Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874iickxki.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=chengminglin@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=takahiro.kuwano@infineon.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox