* [PATCH v2] ALSA: hda/realtek: fix bad indentation for alc269
@ 2026-03-31 2:40 Lei Huang
2026-03-31 6:51 ` Takashi Iwai
2026-04-01 10:42 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Lei Huang @ 2026-03-31 2:40 UTC (permalink / raw)
To: perex, tiwai; +Cc: linux-sound, linux-kernel, Lei Huang
From: Lei Huang <huanglei@kylinos.cn>
Mention complains about this coding style:
ERROR: code indent should use tabs where possible
#6640: FILE: sound/hda/codecs/realtek/alc269.c:6640:
+ [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {$
fix it up.
Fixes: 5de5db35350d ("ALSA: hda/realtek - Enable Mute LED for Lenovo platform")
Signed-off-by: Lei Huang <huanglei@kylinos.cn>
---
sound/hda/codecs/realtek/alc269.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index b6a58852752a..09af4d378b30 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6637,10 +6637,10 @@ static const struct hda_fixup alc269_fixups[] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc288_fixup_surface_swap_dacs,
},
- [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {
- .type = HDA_FIXUP_FUNC,
- .v.func = alc233_fixup_lenovo_gpio2_mic_hotkey,
- },
+ [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {
+ .type = HDA_FIXUP_FUNC,
+ .v.func = alc233_fixup_lenovo_gpio2_mic_hotkey,
+ },
[ALC245_FIXUP_BASS_HP_DAC] = {
.type = HDA_FIXUP_FUNC,
/* Borrow the DAC routing selected for those Thinkpads */
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] ALSA: hda/realtek: fix bad indentation for alc269
2026-03-31 2:40 [PATCH v2] ALSA: hda/realtek: fix bad indentation for alc269 Lei Huang
@ 2026-03-31 6:51 ` Takashi Iwai
2026-04-01 10:42 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2026-03-31 6:51 UTC (permalink / raw)
To: Lei Huang; +Cc: perex, tiwai, linux-sound, linux-kernel, Lei Huang
On Tue, 31 Mar 2026 04:40:36 +0200,
Lei Huang wrote:
>
> From: Lei Huang <huanglei@kylinos.cn>
>
> Mention complains about this coding style:
>
> ERROR: code indent should use tabs where possible
> #6640: FILE: sound/hda/codecs/realtek/alc269.c:6640:
> + [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {$
>
> fix it up.
>
> Fixes: 5de5db35350d ("ALSA: hda/realtek - Enable Mute LED for Lenovo platform")
> Signed-off-by: Lei Huang <huanglei@kylinos.cn>
Applied to for-next branch now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] ALSA: hda/realtek: fix bad indentation for alc269
2026-03-31 2:40 [PATCH v2] ALSA: hda/realtek: fix bad indentation for alc269 Lei Huang
2026-03-31 6:51 ` Takashi Iwai
@ 2026-04-01 10:42 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-01 10:42 UTC (permalink / raw)
To: Lei Huang, perex, tiwai; +Cc: linux-sound, linux-kernel, Lei Huang
On 31/03/2026 04:40, Lei Huang wrote:
> From: Lei Huang <huanglei@kylinos.cn>
>
> Mention complains about this coding style:
>
> ERROR: code indent should use tabs where possible
> #6640: FILE: sound/hda/codecs/realtek/alc269.c:6640:
> + [ALC233_FIXUP_LENOVO_GPIO2_MIC_HOTKEY] = {$
>
> fix it up.
>
> Fixes: 5de5db35350d ("ALSA: hda/realtek - Enable Mute LED for Lenovo platform")
Really, no. This is not a bug, otherwise explain user observable problem
here.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-01 10:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-31 2:40 [PATCH v2] ALSA: hda/realtek: fix bad indentation for alc269 Lei Huang
2026-03-31 6:51 ` Takashi Iwai
2026-04-01 10:42 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox