From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20C65335546 for ; Thu, 5 Mar 2026 07:54:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772697282; cv=none; b=WSbPL5Rb+3BJgvfMyRfLultv3e0ZbJd8G5Bj9kNrezI1lzLWQwdq6iRks2EGSgbK6X+6apx5UbNCQfEkHC3Pa8Hpr2xtiPgwdWBrOtdvNsZ4Ecs6QNG1S66oDNCFGItERAaP1ypGf9mnUR/8VUIAewBtvXsuWSxwkEwjg12YlCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772697282; c=relaxed/simple; bh=X6OTzh3WYoi0bidWZYMLL81kQKeHK2GJN9E/O37+9IY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Nmx4InkNk89iKJb0OmeFcqbgxRTrO5rzvR4b3gGrHYTgtWFXGgD14GltIQK/rHaI4s8RGyW3umIsvqJ4f3jcCQ2sJjaSNYOiokA7ezCk14AWlpmVYLAewSrwvfU2sRWKfoP19utqcPcPhz83ZbaI1qWlpCIBeAlw9uM1Ik1tJ9w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=lhxI5l8/; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="lhxI5l8/" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 5B6B01A2CD2; Thu, 5 Mar 2026 07:54:38 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 28BF15FDEB; Thu, 5 Mar 2026 07:54:38 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 4AFD51036981A; Thu, 5 Mar 2026 08:54:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1772697277; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=INGbhC1k38Jrr8kD8M8GCyeZ7uJijtC0Me4SABhYQmg=; b=lhxI5l8/VONdMAIwqs/2IElcJc+GoI3Y+SJON2PZaZFs8Vq54FxfiqMoB6j58Jg4LyKxoN XKzzVE8KbVMV50C0QbPLInENombI2kH+esU68DR4+uaQtUHcDAPboa/g0SYlU05D8ksXPa 92ZE8P+kEg4icw/xhHb9nMq9aSoZeWUd/G2Jg/8NnvpISdvG5eyTACg6K2NDkFUVShQoGL IL15RxAr7cENNulbAT+OwLAQow3ue423grgkoHNFKM2dvmBZEGx2iYBwedZcSNs3U9KayG wmHaw0WmPC5rK+yHhIqK7ZWxb49/mFveEM5pq5+esQE7Ppvv+9Io0/SGeTniow== From: Gregory CLEMENT To: Andrew Lunn , Gabor Juhos Cc: Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' properties In-Reply-To: References: <20260304-armada-37xx-drop-usb-misc-reg-v1-1-800c1b746b7a@gmail.com> Date: Thu, 05 Mar 2026 08:54:34 +0100 Message-ID: <874imug18l.fsf@BLaptop.bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello Andrew, > On Wed, Mar 04, 2026 at 08:12:43PM +0100, Gabor Juhos wrote: >> The 'marvell,usb-misc-reg' property is present both in the EHCI and >> in the XHCI USB host device nodes, however it is not documented. Thus >> 'make dtbs_check' produces warnings like these: >>=20 >> /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@58000 (marvell,ar= mada3700-xhci): Unevaluated properties are not allowed ('marvell,usb-misc-r= eg' was unexpected) >> from schema $id: http://devicetree.org/schemas/usb/generic-xhc= i.yaml >> /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@5e000 (marvell,ar= mada-3700-ehci): Unevaluated properties are not allowed ('marvell,usb-misc-= reg' was unexpected) >> from schema $id: http://devicetree.org/schemas/usb/generic-ehc= i.yaml >>=20 >> Apart from the fact that the properties are not documented, those are >> not even used by any USB host drivers. At least 'git grep' says this: >>=20 >> $ git grep -n 'marvell.usb-misc-reg' v7.0-rc2 >> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utm= i-phy.yaml:30: marvell,usb-misc-reg: >> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utm= i-phy.yaml:41: - marvell,usb-misc-reg >> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utm= i-phy.yaml:50: marvell,usb-misc-reg =3D <&usb2_syscon>; >> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:372: = marvell,usb-misc-reg =3D <&usb32_syscon>; >> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:383: = marvell,usb-misc-reg =3D <&usb32_syscon>; >> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:396: = marvell,usb-misc-reg =3D <&usb2_syscon>; >> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:406: = marvell,usb-misc-reg =3D <&usb2_syscon>; >> v7.0-rc2:drivers/phy/marvell/phy-mvebu-a3700-utmi.c:231: = "marvell,usb-misc-reg"); > I don't follow: > The phy-mvebu-a3700-utmi.c does use it, and does document it: > > marvell,usb-misc-reg: > description: > Phandle on the "USB miscellaneous registers" shared region > covering registers related to both the host controller and > the PHY. > $ref: /schemas/types.yaml#/definitions/phandle > > And the patch which added the property to the USB nodes also added the > PHY nodes. > > commit 05d168a56fae8ff50432d5dfe6e7423b989455a8 > Author: Miquel Raynal > Date: Tue Jan 29 10:36:34 2019 +0100 > > arm64: dts: marvell: armada-37xx: declare USB2 UTMI PHYs > You stated that the property is used and was properly added. > So this change does lookcorrect. But here you agree with removing it. I am lost :) Gregory > > Reviewed-by: Andrew Lunn > > Andrew --=20 Gr=C3=A9gory CLEMENT, Bootlin Embedded Linux and Kernel engineering https://bootlin.com