* [PATCH] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' properties
@ 2026-03-04 19:12 Gabor Juhos
2026-03-04 19:48 ` Andrew Lunn
0 siblings, 1 reply; 6+ messages in thread
From: Gabor Juhos @ 2026-03-04 19:12 UTC (permalink / raw)
To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, devicetree, linux-kernel, Gabor Juhos
The 'marvell,usb-misc-reg' property is present both in the EHCI and
in the XHCI USB host device nodes, however it is not documented. Thus
'make dtbs_check' produces warnings like these:
/arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@58000 (marvell,armada3700-xhci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
from schema $id: http://devicetree.org/schemas/usb/generic-xhci.yaml
/arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@5e000 (marvell,armada-3700-ehci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yaml
Apart from the fact that the properties are not documented, those are
not even used by any USB host drivers. At least 'git grep' says this:
$ git grep -n 'marvell.usb-misc-reg' v7.0-rc2
v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:30: marvell,usb-misc-reg:
v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:41: - marvell,usb-misc-reg
v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:50: marvell,usb-misc-reg = <&usb2_syscon>;
v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:372: marvell,usb-misc-reg = <&usb32_syscon>;
v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:383: marvell,usb-misc-reg = <&usb32_syscon>;
v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:396: marvell,usb-misc-reg = <&usb2_syscon>;
v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:406: marvell,usb-misc-reg = <&usb2_syscon>;
v7.0-rc2:drivers/phy/marvell/phy-mvebu-a3700-utmi.c:231: "marvell,usb-misc-reg");
Due to this, drop the properties for now in order to get rid of the
warnings.
Given that the platform is quite old, and its support is mature enough,
it is highly unlikely that the properties will be used in the future.
Even, if that is not the case and the properties will be needed later
by any chance, those can be added back along with the supporting code
and with a proper documentation.
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
---
arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index ea1824f5321fbb32fc4373c08a0d94bca1dc793b..44c47409f8793ae1266303607812ef481edbfbc5 100644
--- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
@@ -369,7 +369,6 @@ usb3: usb@58000 {
compatible = "marvell,armada3700-xhci",
"generic-xhci";
reg = <0x58000 0x4000>;
- marvell,usb-misc-reg = <&usb32_syscon>;
interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&sb_periph_clk 12>;
phys = <&comphy0 0>, <&usb2_utmi_otg_phy>;
@@ -393,7 +392,6 @@ usb32_syscon: system-controller@5d800 {
usb2: usb@5e000 {
compatible = "marvell,armada-3700-ehci";
reg = <0x5e000 0x1000>;
- marvell,usb-misc-reg = <&usb2_syscon>;
interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usb2_utmi_host_phy>;
phy-names = "usb";
---
base-commit: 98226a594f313442fcba38cefc1df0b6c1691c7e
change-id: 20260304-armada-37xx-drop-usb-misc-reg-e9635498cae6
Best regards,
--
Gabor Juhos <j4g8y7@gmail.com>
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' properties
2026-03-04 19:12 [PATCH] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' properties Gabor Juhos
@ 2026-03-04 19:48 ` Andrew Lunn
2026-03-05 7:54 ` Gregory CLEMENT
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2026-03-04 19:48 UTC (permalink / raw)
To: Gabor Juhos
Cc: Gregory Clement, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
linux-kernel
On Wed, Mar 04, 2026 at 08:12:43PM +0100, Gabor Juhos wrote:
> The 'marvell,usb-misc-reg' property is present both in the EHCI and
> in the XHCI USB host device nodes, however it is not documented. Thus
> 'make dtbs_check' produces warnings like these:
>
> /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@58000 (marvell,armada3700-xhci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
> from schema $id: http://devicetree.org/schemas/usb/generic-xhci.yaml
> /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@5e000 (marvell,armada-3700-ehci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
> from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yaml
>
> Apart from the fact that the properties are not documented, those are
> not even used by any USB host drivers. At least 'git grep' says this:
>
> $ git grep -n 'marvell.usb-misc-reg' v7.0-rc2
> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:30: marvell,usb-misc-reg:
> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:41: - marvell,usb-misc-reg
> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:50: marvell,usb-misc-reg = <&usb2_syscon>;
> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:372: marvell,usb-misc-reg = <&usb32_syscon>;
> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:383: marvell,usb-misc-reg = <&usb32_syscon>;
> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:396: marvell,usb-misc-reg = <&usb2_syscon>;
> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:406: marvell,usb-misc-reg = <&usb2_syscon>;
> v7.0-rc2:drivers/phy/marvell/phy-mvebu-a3700-utmi.c:231: "marvell,usb-misc-reg");
The phy-mvebu-a3700-utmi.c does use it, and does document it:
marvell,usb-misc-reg:
description:
Phandle on the "USB miscellaneous registers" shared region
covering registers related to both the host controller and
the PHY.
$ref: /schemas/types.yaml#/definitions/phandle
And the patch which added the property to the USB nodes also added the
PHY nodes.
commit 05d168a56fae8ff50432d5dfe6e7423b989455a8
Author: Miquel Raynal <miquel.raynal@bootlin.com>
Date: Tue Jan 29 10:36:34 2019 +0100
arm64: dts: marvell: armada-37xx: declare USB2 UTMI PHYs
So this change does look correct.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' properties
2026-03-04 19:48 ` Andrew Lunn
@ 2026-03-05 7:54 ` Gregory CLEMENT
2026-03-05 13:28 ` Andrew Lunn
0 siblings, 1 reply; 6+ messages in thread
From: Gregory CLEMENT @ 2026-03-05 7:54 UTC (permalink / raw)
To: Andrew Lunn, Gabor Juhos
Cc: Sebastian Hesselbarth, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-kernel, devicetree, linux-kernel
Hello Andrew,
> On Wed, Mar 04, 2026 at 08:12:43PM +0100, Gabor Juhos wrote:
>> The 'marvell,usb-misc-reg' property is present both in the EHCI and
>> in the XHCI USB host device nodes, however it is not documented. Thus
>> 'make dtbs_check' produces warnings like these:
>>
>> /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@58000 (marvell,armada3700-xhci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
>> from schema $id: http://devicetree.org/schemas/usb/generic-xhci.yaml
>> /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@5e000 (marvell,armada-3700-ehci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
>> from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yaml
>>
>> Apart from the fact that the properties are not documented, those are
>> not even used by any USB host drivers. At least 'git grep' says this:
>>
>> $ git grep -n 'marvell.usb-misc-reg' v7.0-rc2
>> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:30: marvell,usb-misc-reg:
>> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:41: - marvell,usb-misc-reg
>> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:50: marvell,usb-misc-reg = <&usb2_syscon>;
>> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:372: marvell,usb-misc-reg = <&usb32_syscon>;
>> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:383: marvell,usb-misc-reg = <&usb32_syscon>;
>> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:396: marvell,usb-misc-reg = <&usb2_syscon>;
>> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:406: marvell,usb-misc-reg = <&usb2_syscon>;
>> v7.0-rc2:drivers/phy/marvell/phy-mvebu-a3700-utmi.c:231: "marvell,usb-misc-reg");
>
I don't follow:
> The phy-mvebu-a3700-utmi.c does use it, and does document it:
>
> marvell,usb-misc-reg:
> description:
> Phandle on the "USB miscellaneous registers" shared region
> covering registers related to both the host controller and
> the PHY.
> $ref: /schemas/types.yaml#/definitions/phandle
>
> And the patch which added the property to the USB nodes also added the
> PHY nodes.
>
> commit 05d168a56fae8ff50432d5dfe6e7423b989455a8
> Author: Miquel Raynal <miquel.raynal@bootlin.com>
> Date: Tue Jan 29 10:36:34 2019 +0100
>
> arm64: dts: marvell: armada-37xx: declare USB2 UTMI PHYs
>
You stated that the property is used and was properly added.
> So this change does lookcorrect.
But here you agree with removing it.
I am lost :)
Gregory
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Andrew
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' properties
2026-03-05 7:54 ` Gregory CLEMENT
@ 2026-03-05 13:28 ` Andrew Lunn
2026-03-05 19:51 ` Gabor Juhos
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2026-03-05 13:28 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: Gabor Juhos, Sebastian Hesselbarth, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
linux-kernel
On Thu, Mar 05, 2026 at 08:54:34AM +0100, Gregory CLEMENT wrote:
> Hello Andrew,
>
> > On Wed, Mar 04, 2026 at 08:12:43PM +0100, Gabor Juhos wrote:
> >> The 'marvell,usb-misc-reg' property is present both in the EHCI and
> >> in the XHCI USB host device nodes, however it is not documented. Thus
> >> 'make dtbs_check' produces warnings like these:
> >>
> >> /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@58000 (marvell,armada3700-xhci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
> >> from schema $id: http://devicetree.org/schemas/usb/generic-xhci.yaml
> >> /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@5e000 (marvell,armada-3700-ehci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
> >> from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yaml
> >>
> >> Apart from the fact that the properties are not documented, those are
> >> not even used by any USB host drivers. At least 'git grep' says this:
> >>
> >> $ git grep -n 'marvell.usb-misc-reg' v7.0-rc2
> >> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:30: marvell,usb-misc-reg:
> >> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:41: - marvell,usb-misc-reg
> >> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:50: marvell,usb-misc-reg = <&usb2_syscon>;
> >> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:372: marvell,usb-misc-reg = <&usb32_syscon>;
> >> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:383: marvell,usb-misc-reg = <&usb32_syscon>;
> >> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:396: marvell,usb-misc-reg = <&usb2_syscon>;
> >> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:406: marvell,usb-misc-reg = <&usb2_syscon>;
> >> v7.0-rc2:drivers/phy/marvell/phy-mvebu-a3700-utmi.c:231: "marvell,usb-misc-reg");
> >
>
> I don't follow:
>
> > The phy-mvebu-a3700-utmi.c does use it, and does document it:
> >
> > marvell,usb-misc-reg:
> > description:
> > Phandle on the "USB miscellaneous registers" shared region
> > covering registers related to both the host controller and
> > the PHY.
> > $ref: /schemas/types.yaml#/definitions/phandle
> >
> > And the patch which added the property to the USB nodes also added the
> > PHY nodes.
> >
> > commit 05d168a56fae8ff50432d5dfe6e7423b989455a8
> > Author: Miquel Raynal <miquel.raynal@bootlin.com>
> > Date: Tue Jan 29 10:36:34 2019 +0100
> >
> > arm64: dts: marvell: armada-37xx: declare USB2 UTMI PHYs
> >
>
> You stated that the property is used and was properly added.
I can understand your confusion. The commit message is not great. I
had to read quite a bit of code to convince myself the change is
correct.
The property is used and documented in the Generic PHY driver,
phy-mvebu-a3700-utmi.c. And the properties being removed are in USB
nodes. The properties in the PHY node are not removed.
The properties in the USB node have never been used, as far as i can
see.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' properties
2026-03-05 13:28 ` Andrew Lunn
@ 2026-03-05 19:51 ` Gabor Juhos
2026-03-13 15:57 ` Gregory CLEMENT
0 siblings, 1 reply; 6+ messages in thread
From: Gabor Juhos @ 2026-03-05 19:51 UTC (permalink / raw)
To: Andrew Lunn, Gregory CLEMENT
Cc: Sebastian Hesselbarth, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-kernel, devicetree, linux-kernel
Hi Andrew,
2026. 03. 05. 14:28 keltezéssel, Andrew Lunn írta:
> On Thu, Mar 05, 2026 at 08:54:34AM +0100, Gregory CLEMENT wrote:
>> Hello Andrew,
>>
>>> On Wed, Mar 04, 2026 at 08:12:43PM +0100, Gabor Juhos wrote:
>>>> The 'marvell,usb-misc-reg' property is present both in the EHCI and
>>>> in the XHCI USB host device nodes, however it is not documented. Thus
>>>> 'make dtbs_check' produces warnings like these:
>>>>
>>>> /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@58000 (marvell,armada3700-xhci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
>>>> from schema $id: http://devicetree.org/schemas/usb/generic-xhci.yaml
>>>> /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@5e000 (marvell,armada-3700-ehci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
>>>> from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yaml
>>>>
>>>> Apart from the fact that the properties are not documented, those are
>>>> not even used by any USB host drivers. At least 'git grep' says this:
>>>>
>>>> $ git grep -n 'marvell.usb-misc-reg' v7.0-rc2
>>>> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:30: marvell,usb-misc-reg:
>>>> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:41: - marvell,usb-misc-reg
>>>> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:50: marvell,usb-misc-reg = <&usb2_syscon>;
>>>> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:372: marvell,usb-misc-reg = <&usb32_syscon>;
>>>> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:383: marvell,usb-misc-reg = <&usb32_syscon>;
>>>> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:396: marvell,usb-misc-reg = <&usb2_syscon>;
>>>> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:406: marvell,usb-misc-reg = <&usb2_syscon>;
>>>> v7.0-rc2:drivers/phy/marvell/phy-mvebu-a3700-utmi.c:231: "marvell,usb-misc-reg");
>>>
>>
>> I don't follow:
>>
>>> The phy-mvebu-a3700-utmi.c does use it, and does document it:
>>>
>>> marvell,usb-misc-reg:
>>> description:
>>> Phandle on the "USB miscellaneous registers" shared region
>>> covering registers related to both the host controller and
>>> the PHY.
>>> $ref: /schemas/types.yaml#/definitions/phandle
>>>
>>> And the patch which added the property to the USB nodes also added the
>>> PHY nodes.
>>>
>>> commit 05d168a56fae8ff50432d5dfe6e7423b989455a8
>>> Author: Miquel Raynal <miquel.raynal@bootlin.com>
>>> Date: Tue Jan 29 10:36:34 2019 +0100
>>>
>>> arm64: dts: marvell: armada-37xx: declare USB2 UTMI PHYs
>>>
>>
>> You stated that the property is used and was properly added.
>
> I can understand your confusion. The commit message is not great. I
> had to read quite a bit of code to convince myself the change is
> correct.
> The property is used and documented in the Generic PHY driver,
> phy-mvebu-a3700-utmi.c. And the properties being removed are in USB
> nodes. The properties in the PHY node are not removed.
>
> The properties in the USB node have never been used, as far as i can
> see.
Thank you for the review, and sorry about the confusing commit message. Perhaps
I should have skipped the 'git grep' part.
@Gregory: Shall I send a v2 with a reworded the commit message?
Regards,
Gabor
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' properties
2026-03-05 19:51 ` Gabor Juhos
@ 2026-03-13 15:57 ` Gregory CLEMENT
0 siblings, 0 replies; 6+ messages in thread
From: Gregory CLEMENT @ 2026-03-13 15:57 UTC (permalink / raw)
To: Gabor Juhos, Andrew Lunn
Cc: Sebastian Hesselbarth, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-kernel, devicetree, linux-kernel
Gabor Juhos <j4g8y7@gmail.com> writes:
> Hi Andrew,
>
> 2026. 03. 05. 14:28 keltezéssel, Andrew Lunn írta:
>> On Thu, Mar 05, 2026 at 08:54:34AM +0100, Gregory CLEMENT wrote:
>>> Hello Andrew,
>>>
>>>> On Wed, Mar 04, 2026 at 08:12:43PM +0100, Gabor Juhos wrote:
>>>>> The 'marvell,usb-misc-reg' property is present both in the EHCI and
>>>>> in the XHCI USB host device nodes, however it is not documented. Thus
>>>>> 'make dtbs_check' produces warnings like these:
>>>>>
>>>>> /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@58000 (marvell,armada3700-xhci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
>>>>> from schema $id: http://devicetree.org/schemas/usb/generic-xhci.yaml
>>>>> /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@5e000 (marvell,armada-3700-ehci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected)
>>>>> from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yaml
>>>>>
>>>>> Apart from the fact that the properties are not documented, those are
>>>>> not even used by any USB host drivers. At least 'git grep' says this:
>>>>>
>>>>> $ git grep -n 'marvell.usb-misc-reg' v7.0-rc2
>>>>> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:30: marvell,usb-misc-reg:
>>>>> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:41: - marvell,usb-misc-reg
>>>>> v7.0-rc2:Documentation/devicetree/bindings/phy/marvell,armada-3700-utmi-phy.yaml:50: marvell,usb-misc-reg = <&usb2_syscon>;
>>>>> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:372: marvell,usb-misc-reg = <&usb32_syscon>;
>>>>> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:383: marvell,usb-misc-reg = <&usb32_syscon>;
>>>>> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:396: marvell,usb-misc-reg = <&usb2_syscon>;
>>>>> v7.0-rc2:arch/arm64/boot/dts/marvell/armada-37xx.dtsi:406: marvell,usb-misc-reg = <&usb2_syscon>;
>>>>> v7.0-rc2:drivers/phy/marvell/phy-mvebu-a3700-utmi.c:231: "marvell,usb-misc-reg");
>>>>
>>>
>>> I don't follow:
>>>
>>>> The phy-mvebu-a3700-utmi.c does use it, and does document it:
>>>>
>>>> marvell,usb-misc-reg:
>>>> description:
>>>> Phandle on the "USB miscellaneous registers" shared region
>>>> covering registers related to both the host controller and
>>>> the PHY.
>>>> $ref: /schemas/types.yaml#/definitions/phandle
>>>>
>>>> And the patch which added the property to the USB nodes also added the
>>>> PHY nodes.
>>>>
>>>> commit 05d168a56fae8ff50432d5dfe6e7423b989455a8
>>>> Author: Miquel Raynal <miquel.raynal@bootlin.com>
>>>> Date: Tue Jan 29 10:36:34 2019 +0100
>>>>
>>>> arm64: dts: marvell: armada-37xx: declare USB2 UTMI PHYs
>>>>
>>>
>>> You stated that the property is used and was properly added.
>>
>> I can understand your confusion. The commit message is not great. I
>> had to read quite a bit of code to convince myself the change is
>> correct.
>
>> The property is used and documented in the Generic PHY driver,
>> phy-mvebu-a3700-utmi.c. And the properties being removed are in USB
>> nodes. The properties in the PHY node are not removed.
>>
>> The properties in the USB node have never been used, as far as i can
>> see.
>
> Thank you for the review, and sorry about the confusing commit message. Perhaps
> I should have skipped the 'git grep' part.
>
> @Gregory: Shall I send a v2 with a reworded the commit message?
Yes please it would be nice if you can do it.
Gregory
>
> Regards,
> Gabor
>
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-03-13 15:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-04 19:12 [PATCH] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' properties Gabor Juhos
2026-03-04 19:48 ` Andrew Lunn
2026-03-05 7:54 ` Gregory CLEMENT
2026-03-05 13:28 ` Andrew Lunn
2026-03-05 19:51 ` Gabor Juhos
2026-03-13 15:57 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox