* drivers/irqchip/irq-aspeed-scu-ic.c:107:27: warning: variable 'mask' set but not used
@ 2026-02-01 1:50 kernel test robot
2026-02-01 15:38 ` [PATCH] irqchip/aspeed-scu-ic: Remove unused variable mask Thomas Gleixner
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2026-02-01 1:50 UTC (permalink / raw)
To: Ryan Chen; +Cc: oe-kbuild-all, linux-kernel, Thomas Gleixner
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 162b42445b585cd89f45475848845db353539605
commit: b2a0c13f8b4fc3f6c8b279fdc4395a5fa57dda5d irqchip/aspeed-scu-ic: Add support for AST2700 SCU interrupt controllers
date: 5 months ago
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20260201/202602010957.9uuKqUkG-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260201/202602010957.9uuKqUkG-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602010957.9uuKqUkG-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/irqchip/irq-aspeed-scu-ic.c: In function 'aspeed_scu_ic_irq_handler_split':
>> drivers/irqchip/irq-aspeed-scu-ic.c:107:27: warning: variable 'mask' set but not used [-Wunused-but-set-variable]
107 | unsigned int sts, mask;
| ^~~~
vim +/mask +107 drivers/irqchip/irq-aspeed-scu-ic.c
101
102 static void aspeed_scu_ic_irq_handler_split(struct irq_desc *desc)
103 {
104 struct aspeed_scu_ic *scu_ic = irq_desc_get_handler_data(desc);
105 struct irq_chip *chip = irq_desc_get_chip(desc);
106 unsigned long bit, enabled, max, status;
> 107 unsigned int sts, mask;
108
109 chained_irq_enter(chip, desc);
110
111 mask = scu_ic->irq_enable;
112 sts = readl(scu_ic->base + scu_ic->isr);
113 enabled = sts & scu_ic->irq_enable;
114 sts = readl(scu_ic->base + scu_ic->isr);
115 status = sts & enabled;
116
117 bit = scu_ic->irq_shift;
118 max = scu_ic->num_irqs + bit;
119
120 for_each_set_bit_from(bit, &status, max) {
121 generic_handle_domain_irq(scu_ic->irq_domain, bit - scu_ic->irq_shift);
122 /* Clear interrupt */
123 writel(BIT(bit), scu_ic->base + scu_ic->isr);
124 }
125
126 chained_irq_exit(chip, desc);
127 }
128
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] irqchip/aspeed-scu-ic: Remove unused variable mask
2026-02-01 1:50 drivers/irqchip/irq-aspeed-scu-ic.c:107:27: warning: variable 'mask' set but not used kernel test robot
@ 2026-02-01 15:38 ` Thomas Gleixner
2026-02-01 16:13 ` [tip: irq/drivers] " tip-bot2 for Thomas Gleixner
2026-02-03 5:31 ` [PATCH] " Ryan Chen
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Gleixner @ 2026-02-01 15:38 UTC (permalink / raw)
To: kernel test robot, Ryan Chen; +Cc: oe-kbuild-all, linux-kernel
The kernel test robot reports:
drivers/irqchip/irq-aspeed-scu-ic.c:107:27: warning: variable 'mask' set but not used
107 | unsigned int sts, mask;
Remove the leftover.
Fixes: b2a0c13f8b4f ("irqchip/aspeed-scu-ic: Add support for AST2700 SCU interrupt controllers")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Closes: https://lore.kernel.org/oe-kbuild-all/202602010957.9uuKqUkG-lkp@intel.com/
---
Seems the aspeed people are too busy to care about their own code....
---
drivers/irqchip/irq-aspeed-scu-ic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/irqchip/irq-aspeed-scu-ic.c
+++ b/drivers/irqchip/irq-aspeed-scu-ic.c
@@ -104,11 +104,10 @@ static void aspeed_scu_ic_irq_handler_sp
struct aspeed_scu_ic *scu_ic = irq_desc_get_handler_data(desc);
struct irq_chip *chip = irq_desc_get_chip(desc);
unsigned long bit, enabled, max, status;
- unsigned int sts, mask;
+ unsigned int sts;
chained_irq_enter(chip, desc);
- mask = scu_ic->irq_enable;
sts = readl(scu_ic->base + scu_ic->isr);
enabled = sts & scu_ic->irq_enable;
sts = readl(scu_ic->base + scu_ic->isr);
^ permalink raw reply [flat|nested] 4+ messages in thread* [tip: irq/drivers] irqchip/aspeed-scu-ic: Remove unused variable mask
2026-02-01 15:38 ` [PATCH] irqchip/aspeed-scu-ic: Remove unused variable mask Thomas Gleixner
@ 2026-02-01 16:13 ` tip-bot2 for Thomas Gleixner
2026-02-03 5:31 ` [PATCH] " Ryan Chen
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot2 for Thomas Gleixner @ 2026-02-01 16:13 UTC (permalink / raw)
To: linux-tip-commits; +Cc: kernel test robot, Thomas Gleixner, x86, linux-kernel
The following commit has been merged into the irq/drivers branch of tip:
Commit-ID: e1f94662d759411fb7da3e4e662ec588c268e1a5
Gitweb: https://git.kernel.org/tip/e1f94662d759411fb7da3e4e662ec588c268e1a5
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Sun, 01 Feb 2026 16:38:36 +01:00
Committer: Thomas Gleixner <tglx@kernel.org>
CommitterDate: Sun, 01 Feb 2026 17:07:03 +01:00
irqchip/aspeed-scu-ic: Remove unused variable mask
The kernel test robot reports:
drivers/irqchip/irq-aspeed-scu-ic.c:107:27: warning: variable 'mask' set but not used
107 | unsigned int sts, mask;
Remove the leftover.
Fixes: b2a0c13f8b4f ("irqchip/aspeed-scu-ic: Add support for AST2700 SCU interrupt controllers")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/874io0h3sz.ffs@tglx
Closes: https://lore.kernel.org/oe-kbuild-all/202602010957.9uuKqUkG-lkp@intel.com/
---
drivers/irqchip/irq-aspeed-scu-ic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-aspeed-scu-ic.c b/drivers/irqchip/irq-aspeed-scu-ic.c
index bee59c8..7398c3b 100644
--- a/drivers/irqchip/irq-aspeed-scu-ic.c
+++ b/drivers/irqchip/irq-aspeed-scu-ic.c
@@ -104,11 +104,10 @@ static void aspeed_scu_ic_irq_handler_split(struct irq_desc *desc)
struct aspeed_scu_ic *scu_ic = irq_desc_get_handler_data(desc);
struct irq_chip *chip = irq_desc_get_chip(desc);
unsigned long bit, enabled, max, status;
- unsigned int sts, mask;
+ unsigned int sts;
chained_irq_enter(chip, desc);
- mask = scu_ic->irq_enable;
sts = readl(scu_ic->base + scu_ic->isr);
enabled = sts & scu_ic->irq_enable;
sts = readl(scu_ic->base + scu_ic->isr);
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] irqchip/aspeed-scu-ic: Remove unused variable mask
2026-02-01 15:38 ` [PATCH] irqchip/aspeed-scu-ic: Remove unused variable mask Thomas Gleixner
2026-02-01 16:13 ` [tip: irq/drivers] " tip-bot2 for Thomas Gleixner
@ 2026-02-03 5:31 ` Ryan Chen
1 sibling, 0 replies; 4+ messages in thread
From: Ryan Chen @ 2026-02-03 5:31 UTC (permalink / raw)
To: Thomas Gleixner, kernel test robot
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Hello Thomas,
Thanks the patch. Appreciate.
Ryan
> Cc: oe-kbuild-all@lists.linux.dev; linux-kernel@vger.kernel.org
> Subject: [PATCH] irqchip/aspeed-scu-ic: Remove unused variable mask
>
>
> The kernel test robot reports:
>
> drivers/irqchip/irq-aspeed-scu-ic.c:107:27: warning: variable 'mask' set but
> not used
> 107 | unsigned int sts, mask;
>
> Remove the leftover.
>
> Fixes: b2a0c13f8b4f ("irqchip/aspeed-scu-ic: Add support for AST2700 SCU
> interrupt controllers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Thomas Gleixner <tglx@kernel.org>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202602010957.9uuKqUkG-lkp@intel.com/
> ---
> Seems the aspeed people are too busy to care about their own code....
> ---
> drivers/irqchip/irq-aspeed-scu-ic.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/irqchip/irq-aspeed-scu-ic.c
> +++ b/drivers/irqchip/irq-aspeed-scu-ic.c
> @@ -104,11 +104,10 @@ static void aspeed_scu_ic_irq_handler_sp
> struct aspeed_scu_ic *scu_ic = irq_desc_get_handler_data(desc);
> struct irq_chip *chip = irq_desc_get_chip(desc);
> unsigned long bit, enabled, max, status;
> - unsigned int sts, mask;
> + unsigned int sts;
>
> chained_irq_enter(chip, desc);
>
> - mask = scu_ic->irq_enable;
> sts = readl(scu_ic->base + scu_ic->isr);
> enabled = sts & scu_ic->irq_enable;
> sts = readl(scu_ic->base + scu_ic->isr);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-03 5:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-01 1:50 drivers/irqchip/irq-aspeed-scu-ic.c:107:27: warning: variable 'mask' set but not used kernel test robot
2026-02-01 15:38 ` [PATCH] irqchip/aspeed-scu-ic: Remove unused variable mask Thomas Gleixner
2026-02-01 16:13 ` [tip: irq/drivers] " tip-bot2 for Thomas Gleixner
2026-02-03 5:31 ` [PATCH] " Ryan Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox