public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: Ian Rogers <irogers@google.com>, kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	x86@kernel.org
Subject: Re: [tip:timers/vdso 12/14] net/rds/ib_cm.c:96:35: sparse: sparse: incorrect type in argument 1 (different modifiers)
Date: Wed, 14 Jan 2026 21:04:22 +0100	[thread overview]
Message-ID: <874ioohsft.ffs@tglx> (raw)
In-Reply-To: <CAP-5=fUyAtf9PQqYvagByK+-=-mN-T1zuLmxuvsPFVVHT3qLXA@mail.gmail.com>

On Wed, Jan 14 2026 at 09:51, Ian Rogers wrote:
> On Wed, Jan 14, 2026 at 8:37 AM kernel test robot <lkp@intel.com> wrote:
> I think there are 2 options:
> 1) ignore the new sparse warning as tech debt for later clean up,
> 2) modify the cast to be "const void*" instead of "void *" and play
> more wac-a-mole.

Option #3:

You might have tried the 'const void*' cast and figured out that sparse
is still unhappy. I actually did, but I didn't try to figure out why as
that's really not my duty.

> My preference would be 1 as I have a suspicion I played 2 and thought
> the non-const cast was best (hence it being in the patch) given other
> issues.

Preferences based on suspicions are not really usefull. Please go and
figure out what's going on and either fix it in the kernel code or tell
the sparse folks what they are missing.

Leaving it unresolved and handwaved away is not an option.

Thanks,

        tglx

  reply	other threads:[~2026-01-14 20:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14 16:36 [tip:timers/vdso 12/14] net/rds/ib_cm.c:96:35: sparse: sparse: incorrect type in argument 1 (different modifiers) kernel test robot
2026-01-14 17:51 ` Ian Rogers
2026-01-14 20:04   ` Thomas Gleixner [this message]
2026-01-14 21:03     ` Ian Rogers
2026-01-14 21:27       ` Thomas Gleixner
2026-01-14 21:42         ` Ian Rogers
2026-01-15 19:28 ` Thomas Gleixner
2026-01-15 21:11   ` Peter Zijlstra
2026-01-15 21:19     ` Linus Torvalds
2026-01-15 21:30       ` Peter Zijlstra
2026-01-15 23:03         ` Linus Torvalds
2026-01-16  8:28           ` Peter Zijlstra
2026-01-15 23:01     ` Thomas Gleixner
2026-01-16 11:25       ` Thomas Gleixner
2026-01-16 18:18         ` [PATCH] compiler: Use __typeof_unqual__() for __unqual_scalar_typeof() Thomas Gleixner
2026-01-17  5:25           ` Ian Rogers
2026-01-17 21:25           ` [tip: timers/vdso] " tip-bot2 for Peter Zijlstra
2026-01-18  9:38           ` tip-bot2 for Peter Zijlstra
2026-02-25  8:15           ` [PATCH] " Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2026-01-14  7:13 [tip:timers/vdso 12/14] net/rds/ib_cm.c:96:35: sparse: sparse: incorrect type in argument 1 (different modifiers) kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ioohsft.ffs@tglx \
    --to=tglx@kernel.org \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox