From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64FED3191DE for ; Mon, 17 Nov 2025 08:12:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763367161; cv=none; b=Z5y1Z0GWhlA7dErg7fCHyIVDbyg7xdrgBrc8PM3338N0QIxlyemqbnkpmUdfUW9KJYTjAafHwdtvmT+XVuWcUX6r6PSvLcdeAd6ufROPRR2fCSzFIk9YnTFbEkdn8gMiIsLoucYufiHyBY+9kRXRKMSeiEx9uqT7ilROwOEDoEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763367161; c=relaxed/simple; bh=sTRa4M6n2/lu7gjmr89fTlPEqzNpsEob/EbE+SS9xiU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=HcYT+21SHij9gkDI3RiGilf1et2Kl2jn1QlScOC8DqA9aasRnnPuy/xuvZ5pY3zu1+P1Ak+jhYkTwJpV9el/jEKM54UV2xrxq0iL+sMggG/mvWFpQYAsKHnAvT0py7DAjGJMX7X4SrDlyJRLg9wYE5o0JcM7NrLQgUReQPMYdeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=n59LmIrm; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="n59LmIrm" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 508EE1A1B5E; Mon, 17 Nov 2025 08:12:33 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 1800F606B9; Mon, 17 Nov 2025 08:12:33 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5980C10371CF0; Mon, 17 Nov 2025 09:12:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763367152; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=Ca1ws7C0a0JMPD5p+/mpJ8vbvGGYtVhejgkFgRsapx8=; b=n59LmIrmJV6jSm/KQRMwLY7GoB61jBei0u1ByftBStdTogkZoYbYsVfEFenN6EhnKQAeI5 5KG+EZ/VXdLs48Dub2cU8TWTxtY2ITG+ulRiyhEbCywkCm7EvjJmaIMH2IXINtyI4tNHUW w9AoFm3kH0J7xxNY8DQ0gWDuDRi3D7OvHkO9i0pge/IqFAwmFqeFa0GP/RglgN3sp/RdNr MTHDL+GgqEOZi0wTE9da8FxyPzIxPgYHBVm7gO9HFIq/LYPB3MxtpmXePuFnJuPwQ5CPYZ euEihXUyVxlX7jRkc7bGKK1dLRRiUEuIPU8wc/quWF/BKCk/77TCr+ehvJnfkA== From: Miquel Raynal To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Robert Jarzmik , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org Subject: Re: [PATCH] mtd: docg3: fix kernel-doc warnings In-Reply-To: <20251116070944.84071-1-rdunlap@infradead.org> (Randy Dunlap's message of "Sat, 15 Nov 2025 23:09:44 -0800") References: <20251116070944.84071-1-rdunlap@infradead.org> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Mon, 17 Nov 2025 09:12:29 +0100 Message-ID: <874iqtf576.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Randy, On 15/11/2025 at 23:09:44 -08, Randy Dunlap wrote: > Fix kernel-doc warnings in docg3.h to avoid build warnings and to > improve and documentation: "to improve and documentation" is incorrect, can you please fix? > Warning: ../drivers/mtd/devices/docg3.h:276 bad line: > Warning: drivers/mtd/devices/docg3.h:299 struct member 'max_block' not > described in 'docg3' > > Signed-off-by: Randy Dunlap > --- > Cc: Robert Jarzmik > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: linux-mtd@lists.infradead.org > --- > drivers/mtd/devices/docg3.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-next-20251114.orig/drivers/mtd/devices/docg3.h > +++ linux-next-20251114/drivers/mtd/devices/docg3.h > @@ -274,11 +274,12 @@ struct docg3_cascade { > * @cascade: the cascade this device belongs to > * @device_id: number of the cascaded DoCG3 device (0, 1, 2 or 3) > * @if_cfg: if true, reads are on 16bits, else reads are on 8bits > - > + * Wrong fix I believe. What make you think a space is relevant here? > * @reliable: if 0, docg3 in normal mode, if 1 docg3 in fast mode, if 2 = in > * reliable mode > * Fast mode implies more errors than normal mode. > * Reliable mode implies that page 2*n and 2*n+1 are clones. > + * @max_block: maximum block number for this device > * @bbt: bad block table cache > * @oob_write_ofs: offset of the MTD where this OOB should belong (ie. i= n next > * page_write) Thanks, Miqu=C3=A8l