From: Thomas Gleixner <tglx@linutronix.de>
To: syzbot <syzbot+5245cb609175fb6e8122@syzkaller.appspotmail.com>,
bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
linux-kernel@vger.kernel.org, mingo@redhat.com,
syzkaller-bugs@googlegroups.com, x86@kernel.org,
Kees Cook <kees@kernel.org>
Cc: Linus Torvalds <torvalds@linuxfoundation.org>
Subject: Re: [syzbot] upstream build error (23)
Date: Tue, 29 Jul 2025 23:17:41 +0200 [thread overview]
Message-ID: <874iuuk87e.ffs@tglx> (raw)
In-Reply-To: <87cy9ikcwh.ffs@tglx>
On Tue, Jul 29 2025 at 21:36, Thomas Gleixner wrote:
> On Tue, Jul 29 2025 at 06:43, syzbot wrote:
> and to keep the call for efi_init() as a symbol for the linker to
> resolve, which obviously fails.
>
> If I change the efi_enabled() stub to __always_inline, it's optimized
> out.
Kees has addressed similar problems in:
8245d47cfaba ("x86: Handle KCOV __init vs inline mismatches")
65c430906eff ("arm64: Handle KCOV __init vs inline mismatches")
c64d6be1a6f8 ("s390: Handle KCOV __init vs inline mismatches")
2424fe1cac4f ("arm: Handle KCOV __init vs inline mismatches")
d01daf9d95c9 ("mips: Handle KCOV __init vs inline mismatch")
> Disabling CONFIG_KCOV_INSTRUMENT_ALL makes it go away. So GCC confuses
> the optimizer when CONFIG_KCOV_INSTRUMENT_ALL is on.
Seems to be GCC 12 specific. GCC13 does not have that problem.
> The kernel is full of such inline (not __always_inline) stub
> conditionals which evaluate to a constant....
And chasing all those stubs and convert them to __always_inline seems to
be a whack-a-mole game.
Can we just stop pretending that GCC12 is KCOV capable?
Thanks,
tglx
next prev parent reply other threads:[~2025-07-29 21:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 13:43 [syzbot] upstream build error (23) syzbot
2025-07-29 14:25 ` Borislav Petkov
2025-07-29 14:32 ` Aleksandr Nogikh
2025-07-29 14:48 ` Borislav Petkov
2025-07-29 19:36 ` Thomas Gleixner
2025-07-29 21:17 ` Thomas Gleixner [this message]
2025-07-29 21:38 ` Linus Torvalds
2025-07-29 21:52 ` Borislav Petkov
2025-07-29 22:11 ` Linus Torvalds
2025-07-29 22:27 ` Kees Cook
2025-07-29 22:12 ` Kees Cook
2025-07-30 10:44 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874iuuk87e.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=syzbot+5245cb609175fb6e8122@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=torvalds@linuxfoundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox