public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Terence Eden <terence.eden@shkspr.mobi>
Cc: maximlevitsky@gmail.com,  richard@nod.at,  vigneshr@ti.com,
	linux-kernel@vger.kernel.org,  linux-mtd@lists.infradead.org
Subject: Re: mtd: rawnand: r852: [PATCH] Fixed a spelling error in the comments
Date: Wed, 19 Feb 2025 14:37:52 +0100	[thread overview]
Message-ID: <874j0qqclr.fsf@bootlin.com> (raw)
In-Reply-To: <CAPFVDHob_mna4DRc91cNVAF85px91NV7gjJr-kbY63EYCnJ=EA@mail.gmail.com> (Terence Eden's message of "Wed, 19 Feb 2025 11:59:10 +0000")

Hello Terence,

On 19/02/2025 at 11:59:10 GMT, Terence Eden <terence.eden@shkspr.mobi> wrote:

> Continuing the work of Commit #8ab1b51 /
> https://lore.kernel.org/linux-mtd/20240923065649.11966-1-shenlichuan@vivo.com/
>
> This fixes a spelling error in the comments and removes an errant newline.
>
> Signed-off-by: Terence Eden <terence.eden@shkspr.mobi>

I'm sorry but the formatting is still wrong:
- Your commit title should be "mtd: rawnand: r852: Fix a spelling error in the comments"
- I recommend you use git-format-patch or b4 to format your patches,
  which will prefix [PATCH] automatically.
- You need to increase the version when you send an iteration, this is
  v2, next will be v3 and this must be also done automatically by the
  tools, the final result should look like "[PATCH vX]".
- When sending a new iteration you need to give a changelog, and do that
outside of the commit log, ie...

> ---

  ^^^
Below these '---'

Thanks,
Miquèl

      reply	other threads:[~2025-02-19 13:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 13:21 [PATCH] Fixed a spelling error in the comments Terence Eden
2025-02-18 13:57 ` Miquel Raynal
2025-02-19 11:59   ` mtd: rawnand: r852: " Terence Eden
2025-02-19 13:37     ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874j0qqclr.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=maximlevitsky@gmail.com \
    --cc=richard@nod.at \
    --cc=terence.eden@shkspr.mobi \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox