From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Vegard Nossum <vegard.nossum@oracle.com>,
Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org,
Allen Pais <apais@linux.microsoft.com>,
Brian Mak <makb@juniper.net>, Jeff Xu <jeffxu@chromium.org>,
Roman Kisel <romank@linux.microsoft.com>,
regressions@lists.linux.dev
Subject: Re: [GIT PULL] execve updates for v6.12-rc1
Date: Thu, 26 Sep 2024 14:09:21 -0500 [thread overview]
Message-ID: <874j625j1a.fsf@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <CAHk-=wiJiePHNw3Whxm9n==h3-JwXojefAN3OiDzT89BO3jDew@mail.gmail.com> (Linus Torvalds's message of "Thu, 26 Sep 2024 11:43:22 -0700")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Thu, 26 Sept 2024 at 11:29, Vegard Nossum <vegard.nossum@oracle.com> wrote:
>>
>> # first bad commit: [fb97d2eb542faf19a8725afbd75cbc2518903210]
>> binfmt_elf, coredump: Log the reason of the failed core dumps
>>
>> I have to admit I don't immediately see what's wrong with the patch.
>
> That commit looks entirely broken.
>
> I *suspect* that the problem is the crazy "get_task_comm()" in that
> takes the task lock inside coredump_report_failure().
>
> But honestly, I'm not going to bother even trying to debug this. The
> whole notion was broken. People who have problems with truncated
> core-files should be looking at their debuggers, not asking the kernel
> for help.
One of the common causes for coredump truncation is weird interactions
between io_uring and the coredump code. (AKA kernel bugs).
That is something you can't ask your debugger to tell you.
So from 10,000 feet I think the idea is sane.
Eric
next prev parent reply other threads:[~2024-09-26 19:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 8:39 [GIT PULL] execve updates for v6.12-rc1 Kees Cook
2024-09-18 10:40 ` pr-tracker-bot
2024-09-26 18:29 ` Vegard Nossum
2024-09-26 18:43 ` Linus Torvalds
2024-09-26 19:09 ` Eric W. Biederman [this message]
2024-09-26 19:17 ` Linus Torvalds
2024-09-26 20:37 ` Eric W. Biederman
2024-09-28 21:09 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j625j1a.fsf@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=apais@linux.microsoft.com \
--cc=jeffxu@chromium.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=makb@juniper.net \
--cc=regressions@lists.linux.dev \
--cc=romank@linux.microsoft.com \
--cc=torvalds@linux-foundation.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox