public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>,  Will Deacon <will@kernel.org>,
	 Robin Murphy <robin.murphy@arm.com>,
	 Jason Gunthorpe <jgg@ziepe.ca>,
	 Kevin Tian <kevin.tian@intel.com>,  Yi Liu <yi.l.liu@intel.com>,
	 David Airlie <airlied@gmail.com>,
	 Daniel Vetter <daniel@ffwll.ch>,
	 Bjorn Andersson <andersson@kernel.org>,
	 Mathieu Poirier <mathieu.poirier@linaro.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	 mst@redhat.com,  Jason Wang <jasowang@redhat.com>,
	 Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	 Mikko Perttunen <mperttunen@nvidia.com>,
	 iommu@lists.linux.dev, dri-devel@lists.freedesktop.org,
	 linux-kernel@vger.kernel.org,
	Jeff Johnson <quic_jjohnson@quicinc.com>,
	ath11k@lists.infradead.org
Subject: Re: [PATCH v2 12/22] wifi: ath11k: Use iommu_paging_domain_alloc()
Date: Tue, 04 Jun 2024 11:19:30 +0300	[thread overview]
Message-ID: <874ja9t90t.fsf@kernel.org> (raw)
In-Reply-To: <20240604015134.164206-13-baolu.lu@linux.intel.com> (Lu Baolu's message of "Tue, 4 Jun 2024 09:51:24 +0800")

Lu Baolu <baolu.lu@linux.intel.com> writes:

> An iommu domain is allocated in ath11k_ahb_fw_resources_init() and is
> attached to ab_ahb->fw.dev in the same function.
>
> Use iommu_paging_domain_alloc() to make it explicit.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>  drivers/net/wireless/ath/ath11k/ahb.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
> index ca0f17ddebba..a469647719f9 100644
> --- a/drivers/net/wireless/ath/ath11k/ahb.c
> +++ b/drivers/net/wireless/ath/ath11k/ahb.c
> @@ -1001,10 +1001,10 @@ static int ath11k_ahb_fw_resources_init(struct ath11k_base *ab)
>  
>  	ab_ahb->fw.dev = &pdev->dev;
>  
> -	iommu_dom = iommu_domain_alloc(&platform_bus_type);
> -	if (!iommu_dom) {
> +	iommu_dom = iommu_paging_domain_alloc(ab_ahb->fw.dev);
> +	if (IS_ERR(iommu_dom)) {
>  		ath11k_err(ab, "failed to allocate iommu domain\n");
> -		ret = -ENOMEM;
> +		ret = PTR_ERR(iommu_dom);
>  		goto err_unregister;
>  	}

Adding Jeff and ath11k list so that they can review this as well.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2024-06-04  8:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04  1:51 [PATCH v2 00/22] iommu: Refactoring domain allocation interface Lu Baolu
2024-06-04  1:51 ` [PATCH v2 01/22] iommu: Add iommu_user_domain_alloc() interface Lu Baolu
2024-06-04  8:03   ` Yi Liu
2024-06-05  2:00     ` Baolu Lu
2024-06-05  6:23       ` Yi Liu
2024-06-06  2:04         ` Baolu Lu
2024-06-04  1:51 ` [PATCH v2 02/22] iommufd: Use iommu_user_domain_alloc() Lu Baolu
2024-06-04 16:51   ` Jason Gunthorpe
2024-06-05  2:17     ` Baolu Lu
2024-06-05 12:02       ` Jason Gunthorpe
2024-06-04  1:51 ` [PATCH v2 03/22] vfio/type1: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 04/22] vhost-vdpa: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 05/22] iommu: Add iommu_paging_domain_alloc() interface Lu Baolu
2024-06-04  1:51 ` [PATCH v2 06/22] drm/msm: Use iommu_paging_domain_alloc() Lu Baolu
2024-06-04  7:48   ` Dmitry Baryshkov
2024-06-04  1:51 ` [PATCH v2 07/22] drm/nouveau/tegra: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 08/22] gpu: host1x: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 09/22] media: nvidia: tegra: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 10/22] media: venus: firmware: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 11/22] ath10k: " Lu Baolu
2024-06-04 13:35   ` Jeff Johnson
2024-06-04 13:39   ` Jeff Johnson
2024-06-04  1:51 ` [PATCH v2 12/22] wifi: ath11k: " Lu Baolu
2024-06-04  8:19   ` Kalle Valo [this message]
2024-06-04 13:34   ` Jeff Johnson
2024-06-04  1:51 ` [PATCH v2 13/22] remoteproc: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 14/22] soc/fsl/qbman: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 15/22] RDMA/usnic: " Lu Baolu
2024-06-04 16:44   ` Jason Gunthorpe
2024-06-04  1:51 ` [PATCH v2 16/22] iommu/vt-d: Add helper to allocate paging domain Lu Baolu
2024-06-04  1:51 ` [PATCH v2 17/22] ARM: dma-mapping: Pass device to arm_iommu_create_mapping() Lu Baolu
2024-06-04  1:51 ` [PATCH v2 18/22] ARM: dma-mapping: Use iommu_paging_domain_alloc() Lu Baolu
2024-06-04  1:51 ` [PATCH v2 19/22] drm/rockchip: " Lu Baolu
2024-06-04  1:51 ` [PATCH v2 20/22] drm/tegra: Remove call to iommu_domain_alloc() Lu Baolu
2024-06-04  1:51 ` [PATCH v2 21/22] iommu: Remove iommu_present() Lu Baolu
2024-06-04  1:51 ` [PATCH v2 22/22] iommu: Remove iommu_domain_alloc() Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ja9t90t.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alex.williamson@redhat.com \
    --cc=andersson@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=baolu.lu@linux.intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=iommu@lists.linux.dev \
    --cc=jasowang@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=jonathanh@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mperttunen@nvidia.com \
    --cc=mst@redhat.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=robin.murphy@arm.com \
    --cc=thierry.reding@gmail.com \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox