From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 776A7200C1; Mon, 18 Mar 2024 10:05:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710756307; cv=none; b=NBYHqZXJmCeveuIEJz+WBSsY9/HFZ6JAHDkoP1/5xXeY7b8brFKp/n4bOrMgt1q0EwPSPvnxoO3wIXFz6nSOhFHiN/pJixYsoR+VyuxB+Ka0T8oP8YR6Rp72kBzCQtCkkDejM65WRhclTAYS7C1RGUwhqnIyu21ln6SFFWJHZSQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710756307; c=relaxed/simple; bh=XfYiU7AOdE2wj+QEuPu+XH/cd9oLr/E7XIUhk8cPF/s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=DANCqmI4Nqy39CQW7fOdiQ9Phh9uVCFMi/t7spVbFHqkhaSNf2MjhPmMxCPIkUzqYCzISbi1n6mMi6lyB1KVuD1bMxvMVdk5H6H8hRydAl80NZweeKu5Y7W3Jvc0hVcfbhGTXaCzmqmmdTG9wQvTTRmQzlPBuJPBhcAsuGH1rr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OOuH3EBG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OOuH3EBG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DA92C433F1; Mon, 18 Mar 2024 10:05:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710756307; bh=XfYiU7AOdE2wj+QEuPu+XH/cd9oLr/E7XIUhk8cPF/s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OOuH3EBG8xPeS2ygRCn9L2UEPhrZss4I8fW5oLvL8Z2xrvWT9vu40DfaLw/I9kNt1 JPUyuCX+645mTXq5wIQ/EHeJjU2YCKvqm/OdWUNaOJ6+h+isxma4M/o5/Rt20CeW/z FoJrvH918A45K7SeiujtEnb/zdciKbz8318lBmsBGaezee5W1STaOhoTUzwYGeBQst xAw1BgtWW2hT2bFk/D2Ac7f7qzh4f2MJeucb0HbWeBiT45HyNIGLSmaLpvKHjnD+Vw Zr12HtTJ0VoCNVTTCKWa6FPssJigodBhGwMrn2eF6r0vHWxxJI7tq/cl5+brkiZm7E i1imzL2w6Pibg== From: Kalle Valo To: "Zhijian Li (Fujitsu)" Cc: "linux-kernel@vger.kernel.org" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH v2 3/3] wifi: ti: Convert sprintf/snprintf to sysfs_emit References: <20240315055211.1347548-1-lizhijian@fujitsu.com> <20240315055211.1347548-3-lizhijian@fujitsu.com> <87cyrrew7f.fsf@kernel.org> <115f3f2f-310f-4474-bdf6-070d5c30876c@fujitsu.com> Date: Mon, 18 Mar 2024 12:05:04 +0200 In-Reply-To: <115f3f2f-310f-4474-bdf6-070d5c30876c@fujitsu.com> (Zhijian Li's message of "Mon, 18 Mar 2024 09:42:51 +0000") Message-ID: <874jd3etyn.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Zhijian Li (Fujitsu)" writes: > Kalle, > > > On 18/03/2024 17:16, Kalle Valo wrote: >> Li Zhijian writes: >> >>> Per filesystems/sysfs.rst, show() should only use sysfs_emit() >>> or sysfs_emit_at() when formatting the value to be returned to user space. >>> >>> coccinelle complains that there are still a couple of functions that use >>> snprintf(). Convert them to sysfs_emit(). >>> >>> sprintf() will be converted as weel if they have. >>> >>> Generally, this patch is generated by >>> make coccicheck M= MODE=patch \ >>> COCCI=scripts/coccinelle/api/device_attr_show.cocci >>> >>> No functional change intended >>> >>> CC: Kalle Valo >>> CC: linux-wireless@vger.kernel.org >>> Signed-off-by: Li Zhijian >>> --- >>> V2: subject updated >>> >>> This is a part of the work "Fix coccicheck device_attr_show warnings"[1] >>> Split them per subsystem so that the maintainer can review it easily >>> [1] https://lore.kernel.org/lkml/20240116041129.3937800-1-lizhijian@fujitsu.com/ >>> Signed-off-by: Li Zhijian >> >> Please resubmit the whole patchset as v3. > > > May I know what's wrong with this V2? or what update should I do in V3 Sorry, my mistake. I didn't see patch 1 and I assumed it was not sent. But I checked patchwork now and I do see all three patches: https://patchwork.kernel.org/project/linux-wireless/list/?series=835497 So no need to resend anything because of this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches