From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-40133.protonmail.ch (mail-40133.protonmail.ch [185.70.40.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E4AEE546; Sun, 31 Dec 2023 00:02:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="PIa1/Fwt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1703980964; x=1704240164; bh=NzTBAR3J7TqlmV8UyI1UxV71fO1hFB/qVw412kUFJcE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=PIa1/FwtZTQ2ITyhtpzTfs/gpygu8d9/KHHnrAJtDv1Xd5EDlYHD6Y2lK2fBQ9hJ5 bYvAyydeznYtidorMjMsDKqDvUJLEsQG7YU3mpBKcgZ856InCtlZbQ46szMFVXkqZ+ YkPVnwZuRTRWAWiqUFJIUPbCza8ekXKxENakMYQvAhFXrywiO0+CAOiXYp86Z9pH/t GcDY0PgdweMxYRN8J6TTRSBj9QtmAKvtlSs/0lGoZmawwaLBcA+65b652hn5S/TqeI TH24Ow2ChDV66qWMggBShd0qnJR7A7cUas/eb3bRRWZH433l+cabad9veH4cu75skM DvIjG2PA9s4/Q== Date: Sun, 31 Dec 2023 00:02:32 +0000 To: Larry Finger From: Rahul Rameshbabu Cc: Kalle Valo , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH wireless 3/5] wifi: b43: Stop/wake correct queue in PIO Tx path when QoS is disabled Message-ID: <874jfzutm5.fsf@protonmail.com> In-Reply-To: References: <20231230045105.91351-1-sergeantsagara@protonmail.com> <20231230045105.91351-4-sergeantsagara@protonmail.com> <877ckvwk5v.fsf@protonmail.com> Feedback-ID: 26003777:user:proton Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, 30 Dec, 2023 16:23:58 -0600 "Larry Finger" wrote: > On 12/30/23 13:43, Rahul Rameshbabu wrote: >> Unfortunately, new firmware would not prevent the need to fix up the >> code with regards to QoS being disabled via the kernel parameter or >> using OpenFW. That said, new firmware could help us drop the fifth patch >> in this series. I am thinking about using b43-fwcutter to extract >> proprietary fw from a newer release of broadcom-wl to see if that makes >> a difference. That said, I am a bit puzzled since the device I am >> testing on released in early 2011, and I used firmware released in late >> 2012. > > Unfortunately, it is very difficult to get the parameters for fwcutter fr= om an > x86 binary. Some of the other architectures are easier. Just tried this with the x86 binary just because and ran into extraction issues as expected. I could not find other architecture options from Broadcom's download page, but I may not have been looking well enough... =E2=9D=AF b43-fwcutter ./wlc_hybrid.o_shipped Sorry, the input file is either wrong or not supported by b43-fwcutter. This file has an unknown MD5sum 6889dbd24abf8006de5cc6eddd138518. https://www.broadcom.com/support/download-search?pg=3DWireless+Embedded+S= olutions+and+RF+Components&pf=3DLegacy+Wireless&pn=3D&pa=3DDriver&po=3D&dk= =3DBCM4331&pl=3D&l=3Dtrue I guess, for now, we can keep the exception for bcm4331 and see if future firmware extractions help. -- Thanks, Rahul Rameshbabu