Re: [DO NOT MERGE v5 09/37] dt-bindings: timer: renesas,tmu: add renesas,tmu-sh7750

Krzysztof Kozlowski
2023-12-05T16:07:24Z

On 05/12/2023 10:45, Yoshinori Sato wrote:
> diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
> index a67e427a9e7e..925c2a691b25 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.yaml
> @@ -21,6 +21,7 @@ properties:
> compatible:
> items:
> - enum:
> + - renesas,tmu-sh7750 # SH7750

Please keep alphabetical order.

> - renesas,tmu-r8a7740 # R-Mobile A1
> - renesas,tmu-r8a774a1 # RZ/G2M
> - renesas,tmu-r8a774b1 # RZ/G2N
> @@ -46,7 +47,14 @@ properties:
>
> interrupts:
> minItems: 2
> - maxItems: 3
> + maxItems: 4

You need to constrain in allOf:if:then: existing and new variants. Old
did not have 4 interrupts.

Best regards,
Krzysztof