Re: [DO NOT MERGE v5 11/37] pci: pci-sh7751: Add SH7751 PCI driver

Geert Uytterhoeven
2023-12-05T13:35:02Z

Hi Arnd,

On Tue, Dec 5, 2023 at 2:26 PM Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote:
> > + bscres = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> > + bsc = devm_ioremap_resource(&pdev->dev, bscres);
> > + if (IS_ERR(bsc))
> > + return PTR_ERR(bsc);
> > +
> > + if (of_property_read_u32_array(pdev->dev.of_node,
> > + "renesas,memory", memory, 2) < 0) {
> > + /*
> > + * If no memory range is specified,
> > + * the entire main memory will be targeted for DMA.
> > + */
> > + memory[0] = memory_start;
> > + memory[1] = memory_end - memory_start;
> > + }
>
> There is a generic "dma-ranges" proerty for describing
> which memory is visible by a bus.

I was just going to give that comment on the bindings patch ;-)

> > --- /dev/null
> > +++ b/drivers/pci/controller/pci-sh7751.h
> > @@ -0,0 +1,76 @@
>
> If the header is only included from one file, just removed
> it and add the register definitions to the driver directly.

$ git grep pci-sh7751.h
arch/sh/drivers/pci/pci-sh4.h:#include "pci-sh7751.h"
drivers/pci/controller/pci-sh7751.c:#include "pci-sh7751.h"

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds