Re: [DO NOT MERGE v5 17/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema

Linus Walleij
2023-12-05T10:00:13Z

Hi Yoshinori,

thanks for your patch!

On Tue, Dec 5, 2023 at 10:46 AM Yoshinori Sato
<ysato@users.sourceforge.jp> wrote:

> + renesas,icr-irlm:
> + type: boolean
> + description: If true ICR.IRLM=1

That's a bit hard to understand. I suppose it's something that need to sometimes
be changed for a system so would be good to document it properly.

> + renesas,ipr-map:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description: |
> + IRQ to IPR mapping definition.
> + 1st - INTEVT
> + 2nd - Register
> + 3rd - bit index

Isn't this table always the same for a certain SoC, e.g. compatible
"renesas,sh7751-intc"?

Then don't keep it in the device tree, just look it up per-soc from a
table in the driver.

Other than that it looks good to me.

Yours,
Linus Walleij