[PATCH v6 0/6] wifi: mwifiex: added code to support host mlme.

[PATCH v6 0/6] wifi: mwifiex: added code to support host mlme.

[David Lin]

[-- Attachment #1: Type: text/plain, Size: 2371 bytes --]

Patch v6:

Correct mailing sequence.

Patch v5:

1. Add host base MLME support enable WPA3 functionalities in both STA and AP mode
2. This feature requires a firmware with corresponding WPA3 key API support
3. This feature and regression test have been covered for IW416
4. This feature is currently enabled and tested only for IW416
5. Changelogs since Patch v4
    a. Enhancement: Add WPA3 AP mode support
    b. Bug fix: In WPA3 STA mode, device gets disconnected from AP when group rekey occurs
    c. Bug fix: STAUT doesn't send WMM IE in Association request when associate to WMM-AP

Patch v4:

1. Correct one bad code segment.
2. Add code to check firmware key api version for host_mlme.

Patch v3:

Clean and clear commit message.

Patch v2:

1. Checkpatch error: pwe[1] -> pwe[0].
2. Remove module parameter 'host_mlme'.
3. Won't advertise NL80211_FEATURE_SAE if host mlme is disabled.

David Lin (6):
  wifi: mwifiex: added code to support host mlme.
  wifi: mwifiex: fixed group rekey issue for WPA3.
  wifi: mwifiex: fixed reassocation issue for WPA3.
  wifi: mwifiex: fixed missing WMM IE for assoc req.
  wifi: mwifiex: supported host mlme for AP mode.
  wifi: mwifiex: added mac address for AP config.

 .../net/wireless/marvell/mwifiex/cfg80211.c   | 420 +++++++++++++++++-
 drivers/net/wireless/marvell/mwifiex/cmdevt.c |  34 +-
 drivers/net/wireless/marvell/mwifiex/decl.h   |  12 +
 drivers/net/wireless/marvell/mwifiex/fw.h     |  36 ++
 drivers/net/wireless/marvell/mwifiex/init.c   |   4 +
 drivers/net/wireless/marvell/mwifiex/ioctl.h  |   6 +
 drivers/net/wireless/marvell/mwifiex/join.c   |  64 ++-
 drivers/net/wireless/marvell/mwifiex/main.c   |  10 +
 drivers/net/wireless/marvell/mwifiex/main.h   |  13 +
 drivers/net/wireless/marvell/mwifiex/scan.c   |   6 +
 drivers/net/wireless/marvell/mwifiex/sdio.c   |  13 +
 drivers/net/wireless/marvell/mwifiex/sdio.h   |   2 +
 .../wireless/marvell/mwifiex/sta_cmdresp.c    |   2 +
 .../net/wireless/marvell/mwifiex/sta_event.c  |  18 +-
 .../net/wireless/marvell/mwifiex/sta_ioctl.c  |   3 +-
 drivers/net/wireless/marvell/mwifiex/sta_tx.c |   9 +-
 .../net/wireless/marvell/mwifiex/uap_cmd.c    | 182 ++++++++
 drivers/net/wireless/marvell/mwifiex/util.c   | 104 +++++
 18 files changed, 919 insertions(+), 19 deletions(-)

-- 
2.25.1


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 13556 bytes --]

Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host mlme.

[Francesco Dolcini]

On Fri, Oct 20, 2023 at 03:48:06AM +0000, David Lin wrote:
> Patch v6:
> Correct mailing sequence.

You are still doing something wrong sending the patches over email, the
various emails are not threaded as expected, git-send-email should do
everything for you.

No need to re-send now IMO, but please figure out what's wrong for the
next time.

To give you an idea here [1] you see this email alone.

This [2] and this [3] are examples of a properly sent patch series (just random
series from your NXP colleagues).

You have also a winmail.dat file attached to every email in this series,
not sure what it is, but I would try to not send it.

Francesco

[1] https://lore.kernel.org/all/PA4PR04MB96388A628D6AB8359D3DAAD0D1DBA@PA4PR04MB9638.eurprd04.prod.outlook.com/
[2] https://lore.kernel.org/all/1697794232-2607-1-git-send-email-shengjiu.wang@nxp.com/
[3] https://lore.kernel.org/all/20230811101232.844769-1-neeraj.sanjaykale@nxp.com/

RE: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host mlme.

[David Lin]

> From: Francesco Dolcini <francesco@dolcini.it>
> Sent: Friday, October 20, 2023 11:25 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> briannorris@chromium.org; kvalo@kernel.org; francesco@dolcini.it; Sharvari
> Harisangam <sharvari.harisangam@nxp.com>; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>
> Subject: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host
> mlme.
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Fri, Oct 20, 2023 at 03:48:06AM +0000, David Lin wrote:
> > Patch v6:
> > Correct mailing sequence.
>
> You are still doing something wrong sending the patches over email, the
> various emails are not threaded as expected, git-send-email should do
> everything for you.
>
> No need to re-send now IMO, but please figure out what's wrong for the next
> time.
>
> To give you an idea here [1] you see this email alone.
>
> This [2] and this [3] are examples of a properly sent patch series (just random
> series from your NXP colleagues).
>
> You have also a winmail.dat file attached to every email in this series, not sure
> what it is, but I would try to not send it.
>

Yes. I can send them as a single e-mail. However, I find other member would send multiple patches as separate e-mails with a cover letter. I think it would be easier for review.

In fact, you can find all patches from following link:

https://patchwork.kernel.org/project/linux-wireless/patch/PA4PR04MB9638DEFC074F41AAEE3AC471D1DBA@PA4PR04MB9638.eurprd04.prod.outlook.com/

> Francesco
>
> [1]
> https://lore.kern/
> el.org%2Fall%2FPA4PR04MB96388A628D6AB8359D3DAAD0D1DBA%40PA4PR0
> 4MB9638.eurprd04.prod.outlook.com%2F&data=05%7C01%7Cyu-hao.lin%40nx
> p.com%7C608c0799062a4eda2dc708dbd180b8d1%7C686ea1d3bc2b4c6fa92cd
> 99c5c301635%7C0%7C0%7C638334123004268118%7CUnknown%7CTWFpbGZ
> sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn
> 0%3D%7C3000%7C%7C%7C&sdata=xG3TByV5kbGXbMvr1NM4YF6uErrE%2Bjw
> ZCRf4J8pqPQc%3D&reserved=0
> [2]
> https://lore.kern/
> el.org%2Fall%2F1697794232-2607-1-git-send-email-shengjiu.wang%40nxp.co
> m%2F&data=05%7C01%7Cyu-hao.lin%40nxp.com%7C608c0799062a4eda2dc7
> 08dbd180b8d1%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63833
> 4123004268118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJ
> QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata
> =Pj2suLqyMdelLbFOnePQMFHD89R1VWxGg437SCzNMrQ%3D&reserved=0
> [3]
> https://lore.kern/
> el.org%2Fall%2F20230811101232.844769-1-neeraj.sanjaykale%40nxp.com%2F
> &data=05%7C01%7Cyu-hao.lin%40nxp.com%7C608c0799062a4eda2dc708dbd
> 180b8d1%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6383341230
> 04268118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
> luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ivxJP8
> uJVfq5VXVj8ru%2FKwRYmdvirlczox08NDRzaNQ%3D&reserved=0

Re: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host mlme.

[Kalle Valo]

David Lin <yu-hao.lin@nxp.com> writes:

>> From: Francesco Dolcini <francesco@dolcini.it>
>> Sent: Friday, October 20, 2023 11:25 PM
>> To: David Lin <yu-hao.lin@nxp.com>
>> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
>> briannorris@chromium.org; kvalo@kernel.org; francesco@dolcini.it; Sharvari
>> Harisangam <sharvari.harisangam@nxp.com>; Pete Hsieh
>> <tsung-hsien.hsieh@nxp.com>
>> Subject: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host
>> mlme.
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On Fri, Oct 20, 2023 at 03:48:06AM +0000, David Lin wrote:
>> > Patch v6:
>> > Correct mailing sequence.
>>
>> You are still doing something wrong sending the patches over email, the
>> various emails are not threaded as expected, git-send-email should do
>> everything for you.
>>
>> No need to re-send now IMO, but please figure out what's wrong for the next
>> time.
>>
>> To give you an idea here [1] you see this email alone.
>>
>> This [2] and this [3] are examples of a properly sent patch series (just random
>> series from your NXP colleagues).
>>
>> You have also a winmail.dat file attached to every email in this series, not sure
>> what it is, but I would try to not send it.
>>
>
> Yes. I can send them as a single e-mail. However, I find other member
> would send multiple patches as separate e-mails with a cover letter. I
> think it would be easier for review.

We are not asking to send the patches as single email. We are asking to
run git send-email only _once_ per patchset to make sure threading is
correct (ie. References and In-Reply-to headers are set). For example,
you can do it like this:

$ git format-patch --base=auto --cover-letter -o outgoing/ main
outgoing/0000-cover-letter.patch
outgoing/0001-First-Commit.patch
outgoing/...

$ git send-email [...] outgoing/

More info:

https://wireless.wiki.kernel.org/en/developers/documentation/git-guide

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

RE: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host mlme.

[David Lin]

> From: Kalle Valo <kvalo@kernel.org>
> Sent: Monday, October 23, 2023 5:08 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: Francesco Dolcini <francesco@dolcini.it>; linux-wireless@vger.kernel.org;
> linux-kernel@vger.kernel.org; briannorris@chromium.org; Sharvari
> Harisangam <sharvari.harisangam@nxp.com>; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>
> Subject: Re: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host
> mlme.
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> David Lin <yu-hao.lin@nxp.com> writes:
>
> >> From: Francesco Dolcini <francesco@dolcini.it>
> >> Sent: Friday, October 20, 2023 11:25 PM
> >> To: David Lin <yu-hao.lin@nxp.com>
> >> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> >> briannorris@chromium.org; kvalo@kernel.org; francesco@dolcini.it;
> >> Sharvari Harisangam <sharvari.harisangam@nxp.com>; Pete Hsieh
> >> <tsung-hsien.hsieh@nxp.com>
> >> Subject: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to
> >> support host mlme.
> >>
> >> Caution: This is an external email. Please take care when clicking
> >> links or opening attachments. When in doubt, report the message using
> >> the 'Report this email' button
> >>
> >>
> >> On Fri, Oct 20, 2023 at 03:48:06AM +0000, David Lin wrote:
> >> > Patch v6:
> >> > Correct mailing sequence.
> >>
> >> You are still doing something wrong sending the patches over email,
> >> the various emails are not threaded as expected, git-send-email
> >> should do everything for you.
> >>
> >> No need to re-send now IMO, but please figure out what's wrong for
> >> the next time.
> >>
> >> To give you an idea here [1] you see this email alone.
> >>
> >> This [2] and this [3] are examples of a properly sent patch series
> >> (just random series from your NXP colleagues).
> >>
> >> You have also a winmail.dat file attached to every email in this
> >> series, not sure what it is, but I would try to not send it.
> >>
> >
> > Yes. I can send them as a single e-mail. However, I find other member
> > would send multiple patches as separate e-mails with a cover letter. I
> > think it would be easier for review.
>
> We are not asking to send the patches as single email. We are asking to run git
> send-email only _once_ per patchset to make sure threading is correct (ie.
> References and In-Reply-to headers are set). For example, you can do it like
> this:
>
> $ git format-patch --base=auto --cover-letter -o outgoing/ main
> outgoing/0000-cover-letter.patch outgoing/0001-First-Commit.patch
> outgoing/...
>
> $ git send-email [...] outgoing/

Thanks for your information. We will follow this way for Patch v7.

>
> More info:
>
> https://wireless/.
> wiki.kernel.org%2Fen%2Fdevelopers%2Fdocumentation%2Fgit-guide&data=05
> %7C01%7Cyu-hao.lin%40nxp.com%7C61329a44c6e344221c0a08dbd3a78bef%
> 7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638336488782298560
> %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJ
> BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JTeuKeS8LQphE
> QYR%2BeBK1ENgR7L9ny0S9Nv15Ku1keE%3D&reserved=0
>
> https://www.ker/
> nel.org%2Fdoc%2Fhtml%2Flatest%2Fprocess%2Fsubmitting-patches.html&data
> =05%7C01%7Cyu-hao.lin%40nxp.com%7C61329a44c6e344221c0a08dbd3a78b
> ef%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638336488782298
> 560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi
> LCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=i5Q5Hj9w6X
> zRo3phK9UcSaOzoHeJbxpmpB2TRIfyhak%3D&reserved=0
>
> --
> https://patchwor/
> k.kernel.org%2Fproject%2Flinux-wireless%2Flist%2F&data=05%7C01%7Cyu-hao
> .lin%40nxp.com%7C61329a44c6e344221c0a08dbd3a78bef%7C686ea1d3bc2b4
> c6fa92cd99c5c301635%7C0%7C0%7C638336488782298560%7CUnknown%7CT
> WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX
> VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TdWVJj9KpejI6kQfQnF9R7u3Ohz8
> U1o9xYiiDUcasag%3D&reserved=0
>
> https://wireless/.
> wiki.kernel.org%2Fen%2Fdevelopers%2Fdocumentation%2Fsubmittingpatches
> &data=05%7C01%7Cyu-hao.lin%40nxp.com%7C61329a44c6e344221c0a08dbd
> 3a78bef%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6383364887
> 82298560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
> luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VjDp0
> T4L%2FjqG2lnHG0EJLpWEA6mAcBCXFhwTwMfakg0%3D&reserved=0

Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host mlme.

[Jeff Johnson]

On 10/20/2023 8:24 AM, Francesco Dolcini wrote:
> On Fri, Oct 20, 2023 at 03:48:06AM +0000, David Lin wrote:
>> Patch v6:
>> Correct mailing sequence.
> 
> You are still doing something wrong sending the patches over email, the
> various emails are not threaded as expected, git-send-email should do
> everything for you.
> 
> No need to re-send now IMO, but please figure out what's wrong for the
> next time.
> 
> To give you an idea here [1] you see this email alone.
> 
> This [2] and this [3] are examples of a properly sent patch series (just random
> series from your NXP colleagues).
> 
> You have also a winmail.dat file attached to every email in this series,
> not sure what it is, but I would try to not send it.
> 
> Francesco
> 
> [1] https://lore.kernel.org/all/PA4PR04MB96388A628D6AB8359D3DAAD0D1DBA@PA4PR04MB9638.eurprd04.prod.outlook.com/
> [2] https://lore.kernel.org/all/1697794232-2607-1-git-send-email-shengjiu.wang@nxp.com/
> [3] https://lore.kernel.org/all/20230811101232.844769-1-neeraj.sanjaykale@nxp.com/
> 

If you are new to contributing to the kernel and don't have an 
established workflow I strongly recommend using b4. It removes a lot of 
steps from the standard workflow.
<https://b4.docs.kernel.org/en/latest/contributor/overview.html>

RE: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host mlme.

[David Lin]

> -----Original Message-----
> From: Jeff Johnson <quic_jjohnson@quicinc.com>
> Sent: Tuesday, October 24, 2023 8:03 AM
> To: Francesco Dolcini <francesco@dolcini.it>; David Lin <yu-hao.lin@nxp.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> briannorris@chromium.org; kvalo@kernel.org; Sharvari Harisangam
> <sharvari.harisangam@nxp.com>; Pete Hsieh <tsung-hsien.hsieh@nxp.com>
> Subject: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host
> mlme.
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On 10/20/2023 8:24 AM, Francesco Dolcini wrote:
> > On Fri, Oct 20, 2023 at 03:48:06AM +0000, David Lin wrote:
> >> Patch v6:
> >> Correct mailing sequence.
> >
> > You are still doing something wrong sending the patches over email,
> > the various emails are not threaded as expected, git-send-email should
> > do everything for you.
> >
> > No need to re-send now IMO, but please figure out what's wrong for the
> > next time.
> >
> > To give you an idea here [1] you see this email alone.
> >
> > This [2] and this [3] are examples of a properly sent patch series
> > (just random series from your NXP colleagues).
> >
> > You have also a winmail.dat file attached to every email in this
> > series, not sure what it is, but I would try to not send it.
> >
> > Francesco
> >
> > [1]
> > https://lore/
> > .kernel.org%2Fall%2FPA4PR04MB96388A628D6AB8359D3DAAD0D1DBA%40
> PA4PR04MB
> >
> 9638.eurprd04.prod.outlook.com%2F&data=05%7C01%7Cyu-hao.lin%40nxp.co
> m%
> >
> 7Cfa233ec6406043013edb08dbd4248bb1%7C686ea1d3bc2b4c6fa92cd99c5c30
> 1635%
> >
> 7C0%7C0%7C638337025651088842%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
> MC4wLjAwM
> >
> DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C
> &sdat
> > a=j%2Fdb7i1jZc5Y%2Fc0s9JUHVmdamBx0Unu9i532CrrEngo%3D&reserved=0
> > [2]
> > https://lore/
> > .kernel.org%2Fall%2F1697794232-2607-1-git-send-email-shengjiu.wang%40n
> >
> xp.com%2F&data=05%7C01%7Cyu-hao.lin%40nxp.com%7Cfa233ec640604301
> 3edb08
> >
> dbd4248bb1%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6383370
> 2565108
> >
> 8842%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMz
> IiLCJBT
> >
> iI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6bh0m%2FKqIX6u
> IvmTLr2K
> > 6YoEs8feeJsrldxgiiDf%2Fn4%3D&reserved=0
> > [3]
> > https://lore/
> > .kernel.org%2Fall%2F20230811101232.844769-1-neeraj.sanjaykale%40nxp.co
> >
> m%2F&data=05%7C01%7Cyu-hao.lin%40nxp.com%7Cfa233ec6406043013edb0
> 8dbd42
> >
> 48bb1%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638337025651
> 088842%
> >
> 7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> TiI6Ik
> >
> 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mleWOeKLaj39Bratl9
> E%2Fn9KsL
> > zx71aippjx50VNt0QI%3D&reserved=0
> >
>
> If you are new to contributing to the kernel and don't have an established
> workflow I strongly recommend using b4. It removes a lot of steps from the
> standard workflow.

Thanks. I will reference it.

> <https://b4.docs/.
> kernel.org%2Fen%2Flatest%2Fcontributor%2Foverview.html&data=05%7C01%
> 7Cyu-hao.lin%40nxp.com%7Cfa233ec6406043013edb08dbd4248bb1%7C686ea
> 1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638337025651088842%7CUnkn
> own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h
> aWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=wAe4ueeaorIDgVIYpkf6x
> 4PpZ5epJynpQOzUiqaGLAs%3D&reserved=0>