public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Wesley Cheng <quic_wcheng@quicinc.com>
Cc: <srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>,
	<perex@perex.cz>, <lgirdwood@gmail.com>, <andersson@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <gregkh@linuxfoundation.org>,
	<Thinh.Nguyen@synopsys.com>, <broonie@kernel.org>,
	<bgoswami@quicinc.com>, <tiwai@suse.com>, <robh+dt@kernel.org>,
	<agross@kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <alsa-devel@alsa-project.org>,
	<devicetree@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<quic_jackp@quicinc.com>, <quic_plai@quicinc.com>
Subject: Re: [PATCH v5 12/32] sound: usb: Export USB SND APIs for modules
Date: Thu, 07 Sep 2023 17:38:50 +0200	[thread overview]
Message-ID: <874jk6at85.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230829210657.9904-13-quic_wcheng@quicinc.com>

On Tue, 29 Aug 2023 23:06:37 +0200,
Wesley Cheng wrote:
> -/*
> - * hw_params callback
> - *
> - * allocate a buffer and set the given audio format.
> - *
> - * so far we use a physically linear buffer although packetize transfer
> - * doesn't need a continuous area.
> - * if sg buffer is supported on the later version of alsa, we'll follow
> - * that.
> - */
> -static int snd_usb_hw_params(struct snd_pcm_substream *substream,
> -			     struct snd_pcm_hw_params *hw_params)
> +int snd_usb_attach_endpoints(struct snd_usb_substream *subs,
> +				struct snd_pcm_hw_params *hw_params)

This doesn't only "attach" endpoints, but it does more other things
that are needed for PCM hw_params procedure.  I'd rather keep
hw_params in the function name instead of creating completely
different one.

Ditto for hw_free.


thanks,

Takashi

  parent reply	other threads:[~2023-09-07 15:52 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29 21:06 [PATCH v5 00/32] Introduce QC USB SND audio offloading support Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 01/32] xhci: add support to allocate several interrupters Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 02/32] xhci: add helper to stop endpoint and wait for completion Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 03/32] xhci: sideband: add initial api to register a sideband entity Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 04/32] usb: host: xhci-mem: Cleanup pending secondary event ring events Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 05/32] usb: host: xhci-mem: Allow for interrupter clients to choose specific index Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 06/32] ASoC: Add SOC USB APIs for adding an USB backend Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 07/32] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add USB_RX port Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 08/32] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 09/32] ASoC: qdsp6: q6afe: Increase APR timeout Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 10/32] ASoC: qcom: Add USB backend ASoC driver for Q6 Wesley Cheng
2023-08-30 12:50   ` Amadeusz Sławiński
2023-08-31 19:34     ` Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 11/32] sound: usb: card: Introduce USB SND platform op callbacks Wesley Cheng
2023-09-07 15:36   ` Takashi Iwai
2023-09-11 17:57     ` Wesley Cheng
2023-09-12 22:36       ` Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 12/32] sound: usb: Export USB SND APIs for modules Wesley Cheng
2023-08-30 12:50   ` Amadeusz Sławiński
2023-08-31 19:36     ` Wesley Cheng
2023-09-07 15:38   ` Takashi Iwai [this message]
2023-09-11 17:58     ` Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 13/32] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition Wesley Cheng
2023-08-31 17:24   ` Rob Herring
2023-08-31 19:25     ` Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 14/32] dt-bindings: usb: xhci: Add num-hc-interrupters definition Wesley Cheng
2023-08-31 17:22   ` Rob Herring
2023-08-29 21:06 ` [PATCH v5 15/32] usb: dwc3: Add DT parameter to specify maximum number of interrupters Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 16/32] usb: host: xhci-plat: Set XHCI max interrupters if property is present Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 17/32] sound: usb: qcom: Add USB QMI definitions Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 18/32] sound: usb: Introduce QC USB SND offloading support Wesley Cheng
2023-09-07 15:51   ` Takashi Iwai
2023-09-11 17:59     ` Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 19/32] sound: usb: card: Check for support for requested audio format Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 20/32] sound: soc: soc-usb: Add PCM format check API for USB backend Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 21/32] sound: soc: qcom: qusb6: Ensure PCM format is supported by USB audio device Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 22/32] sound: usb: Prevent starting of audio stream if in use Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 23/32] ASoC: dt-bindings: Add Q6USB backend Wesley Cheng
2023-08-31 17:29   ` Rob Herring
2023-08-31 19:32     ` Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 24/32] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Wesley Cheng
2023-08-31 17:29   ` Rob Herring
2023-08-29 21:06 ` [PATCH v5 25/32] ASoC: qcom: qdsp6: q6afe: Split USB AFE dev_token param into separate API Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 26/32] sound: Pass USB SND card and PCM information to SOC USB Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 27/32] sound: soc: qdsp6: Add SND kcontrol to select offload device Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 28/32] sound: soc: qdsp6: Add SND kcontrol for fetching offload status Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 29/32] sound: soc: qcom: q6usb: Add headphone jack for offload connection status Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 30/32] sound: usb: qc_audio_offload: Use card and PCM index from QMI request Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 31/32] sound: usb: card: Allow for rediscovery of connected USB SND devices Wesley Cheng
2023-08-29 21:06 ` [PATCH v5 32/32] sound: soc: soc-usb: Rediscover USB SND devices on USB port add Wesley Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jk6at85.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=agross@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andersson@kernel.org \
    --cc=bgoswami@quicinc.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=perex@perex.cz \
    --cc=quic_jackp@quicinc.com \
    --cc=quic_plai@quicinc.com \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox