From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C396C0015E for ; Wed, 19 Jul 2023 06:02:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230061AbjGSGBH (ORCPT ); Wed, 19 Jul 2023 02:01:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbjGSGBE (ORCPT ); Wed, 19 Jul 2023 02:01:04 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9F831BF5 for ; Tue, 18 Jul 2023 23:01:03 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0918D218FE; Wed, 19 Jul 2023 06:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689746462; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dgQgxlFcepDaInfoxrsHrXxt5AXoVTbhkF6IGVf5cpg=; b=h+0Ruqz2CalI1XiDmKNvlyGndFSw7ERXP+PZjYhItCW7Wa8qHRlYAyS+ImQm6rKrLeis8T 7Qs1ZGhvKdfO801WdT2Wa4eWTt2q1LoAFabYJnIOz5qXgTySXpm71BOtQoxv0TQg1lDKfb 2hanErmJryg7pAGehHTL75Q4sLrVXJ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689746462; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dgQgxlFcepDaInfoxrsHrXxt5AXoVTbhkF6IGVf5cpg=; b=OngDeZ4SaqRjusrxyHy6gBD4FR6gZjmfsTpJ87Z+foKyZS0MV5RgCVILNvMK/W4hD76mOR zHOm9Lfjp21/A+DQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A311C1361C; Wed, 19 Jul 2023 06:01:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eALPJh18t2TXMgAAMHmgww (envelope-from ); Wed, 19 Jul 2023 06:01:01 +0000 Date: Wed, 19 Jul 2023 08:01:00 +0200 Message-ID: <874jm0modf.wl-tiwai@suse.de> From: Takashi Iwai To: Kai Vehmanen Cc: Maarten Lankhorst , Alsa-devel , sound-open-firmware@alsa-project.org, linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Mark Brown , Daniel Baluta , Matthew Auld Subject: Re: [PATCH 6/7] ASoC: SOF: Intel: Remove deferred probe for SOF In-Reply-To: References: <20230718084522.116952-1-maarten.lankhorst@linux.intel.com> <20230718084522.116952-7-maarten.lankhorst@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Jul 2023 19:04:41 +0200, Kai Vehmanen wrote: > > > diff --git a/sound/soc/sof/intel/hda-codec.c b/sound/soc/sof/intel/hda-codec.c > > index f1fd5b44aaac9..344b61576c0e3 100644 > > --- a/sound/soc/sof/intel/hda-codec.c > > +++ b/sound/soc/sof/intel/hda-codec.c > > @@ -415,7 +415,7 @@ int hda_codec_i915_init(struct snd_sof_dev *sdev) > > return 0; > > > > /* i915 exposes a HDA codec for HDMI audio */ > > - ret = snd_hdac_i915_init(bus, true); > > + ret = snd_hdac_i915_init(bus, false); > > if (ret < 0) > > return ret; > > My only bigger concern is corner cases where the display PCI device is on > the bus and visible to kernel, but for some reason there is no working > driver in the system or it is disabled. > > With this patch, not having a workign display driver means that there is > also no audio in the system as the SOF driver will never get probed. > > In current mainline, one will get the 60sec timeout warning and then > audio driver will proceed to probe and you'll have audio support (minus > HDMI/DP). Yeah, that was a concern in the past, too. e.g. when you pass "nomodeset" boot option, the driver will become unusable, even if the bus is used generically for both analog and HDMI codecs. > This is mostly an issue with very new hardware (e.g. hw is still > behind force_probe flag in xe/i915 driver), but we've had some odd > cases with e.g. systems with both Intel IGFX and other vendors' DGPU. > Audio drivers see the Intel VGA controller in system and will > call snd_hdac_i915_init(), but the audio component bind will never > succeed if the the Intel IGFX is not in actual use. > > Will need a bit of time to think about possible scenarios. Possibly this > is not an issue outside early development systems. In theory if IGFX is > disabled in BIOS, and not visible to OS, we are good, and if it's visible, > the i915/xe driver should be loaded, so we are good again. The 60 seconds timeout is a thing "better than complete disablement", so it's not ideal, either. Maybe we can add something like the following: - Check when the deferred probe takes too long, and warn it - Provide some runtime option to disable the component binding, so that user can work around it if needed thanks, Takashi