From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECB78C6FA82 for ; Tue, 13 Sep 2022 16:29:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232041AbiIMQ3c (ORCPT ); Tue, 13 Sep 2022 12:29:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232434AbiIMQ2i (ORCPT ); Tue, 13 Sep 2022 12:28:38 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C05487C324 for ; Tue, 13 Sep 2022 08:24:05 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1CB7434767; Tue, 13 Sep 2022 15:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663082501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jCwdsZHjxPGGiGBXIrdEwcvTl9L7wQxJY4/o2ien4ok=; b=xyIQEu8zZLW8T9vl1Ly75KX5TWGFnVke9XxfE3h3NH2NxT6S37BcXWKn5ZixGI8uMSfvJ8 xAJugtSrAZ1n8kUb+6SRYTRV2nt+r/ooo7Wyy1HCSsbsNtvg8eU8yaosASXIUSA4k8lDtx RbV6ijMJCFv6cZCo8v1uvqJ+qfAcINY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663082501; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jCwdsZHjxPGGiGBXIrdEwcvTl9L7wQxJY4/o2ien4ok=; b=dYow5v6prfwQR8Y2hk1GpdUP+PGyf3SmDKUFMVDLXue/mwoFnEbyeinbLsczPkj3h0tOPN Iq9qUWLPeSb9aKAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DAD07139B3; Tue, 13 Sep 2022 15:21:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PRuXNASgIGMQUwAAMHmgww (envelope-from ); Tue, 13 Sep 2022 15:21:40 +0000 Date: Tue, 13 Sep 2022 17:21:40 +0200 Message-ID: <874jxbfgfv.wl-tiwai@suse.de> From: Takashi Iwai To: Cezary Rojewski Cc: Gaosheng Cui , , , , , , , , , , , Subject: Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec In-Reply-To: <39b0bfef-be7d-05a9-d964-19a74757bb8d@intel.com> References: <20220822035133.2147381-1-cuigaosheng1@huawei.com> <39b0bfef-be7d-05a9-d964-19a74757bb8d@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Sep 2022 16:03:35 +0200, Cezary Rojewski wrote: > > On 2022-08-22 5:51 AM, Gaosheng Cui wrote: > > In configurations with CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC=n, > > gcc warns about an unused variable: > > > > sound/soc/intel/skylake/skl.c: In function ˇprobe_codec˘: > > sound/soc/intel/skylake/skl.c:729:18: error: unused variable ˇskl˘ [-Werror=unused-variable] > > struct skl_dev *skl = bus_to_skl(bus); > > ^~~ > > cc1: all warnings being treated as errors > > > > Fixes: 3fd63658caed9 ("ASoC: Intel: Drop hdac_ext usage for codec device creation") > > Signed-off-by: Gaosheng Cui > > Thanks for the fix. > > Acked-by: Cezary Rojewski Applied now. Takashi