Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec

Cezary Rojewski
2022-09-13T14:04:29Z

On 2022-08-22 5:51 AM, Gaosheng Cui wrote:
> In configurations with CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC=n,
> gcc warns about an unused variable:
>
> sound/soc/intel/skylake/skl.c: In function ‘probe_codec’:
> sound/soc/intel/skylake/skl.c:729:18: error: unused variable ‘skl’ [-Werror=unused-variable]
> struct skl_dev *skl = bus_to_skl(bus);
> ^~~
> cc1: all warnings being treated as errors
>
> Fixes: 3fd63658caed9 ("ASoC: Intel: Drop hdac_ext usage for codec device creation")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>

Thanks for the fix.

Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>

> ---
> sound/soc/intel/skylake/skl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
> index c7c1cad2a753..52a041d6144c 100644
> --- a/sound/soc/intel/skylake/skl.c
> +++ b/sound/soc/intel/skylake/skl.c
> @@ -726,8 +726,8 @@ static int probe_codec(struct hdac_bus *bus, int addr)
> unsigned int cmd = (addr << 28) | (AC_NODE_ROOT << 20) |
> (AC_VERB_PARAMETERS << 8) | AC_PAR_VENDOR_ID;
> unsigned int res = -1;
> - struct skl_dev *skl = bus_to_skl(bus);
> #if IS_ENABLED(CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC)
> + struct skl_dev *skl = bus_to_skl(bus);
> struct hdac_hda_priv *hda_codec;
> #endif
> struct hda_codec *codec;