From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D187CCA479 for ; Wed, 13 Jul 2022 13:10:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235972AbiGMNKt (ORCPT ); Wed, 13 Jul 2022 09:10:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235769AbiGMNKn (ORCPT ); Wed, 13 Jul 2022 09:10:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF89DDEC6; Wed, 13 Jul 2022 06:10:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A0E061C44; Wed, 13 Jul 2022 13:10:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6D90C34114; Wed, 13 Jul 2022 13:10:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657717841; bh=grGkUc3D+IG+DZrJbKuNKawjh32B2s20ZjA++y40M1k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qRkyDkrvAUpQmZqGueeCpxzDaKUXet2jxabh06alBveQOw2Pjqyw1VgdM2X9ymlVC Mr0SJCEHHPhivTdLPh/efvnNYLeTX686lp+n7GwXRfYq5ULzSxH2sLutBv0Ddrdxbo l/d+d08/wl+eYJYHpmp3nFl4dfApssvDdGbeofa+g6by3Mv9p9wilmES9T2sp/JCKg 2U5erzg0g8ds3MZFZHqRRNbXuQXBZ1JylpzVr8jrjZloiJtNGso6X+elevPDARYtw8 EuX9BTVM5EmM1pOfD/yB7G+h0br2ozWI3ytIlXRQ3xQTaBBoX/hxSjdxNYPrJ2IGlp nqU32Juzk/SCw== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oBc8V-007Dgp-Iz; Wed, 13 Jul 2022 14:10:39 +0100 Date: Wed, 13 Jul 2022 14:10:39 +0100 Message-ID: <874jzl17lc.wl-maz@kernel.org> From: Marc Zyngier To: Robert Marko Cc: Manivannan Sadhasivam , Bjorn Andersson , Andy Gross , Linus Walleij , linux-arm-msm , linux-gpio@vger.kernel.org, open list Subject: Re: [PATCH] pinctrl: qcom: spmi-gpio: make the irqchip immutable In-Reply-To: References: <20220624195112.894916-1-robimarko@gmail.com> <87edyq1ujr.wl-maz@kernel.org> <20220712124445.GC21746@workstation> <87czea1i2f.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: robimarko@gmail.com, manivannan.sadhasivam@linaro.org, bjorn.andersson@linaro.org, agross@kernel.org, linus.walleij@linaro.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Jul 2022 13:33:32 +0100, Robert Marko wrote: > > On Wed, 13 Jul 2022 at 13:47, Marc Zyngier wrote: > > > > On 2022-07-13 12:08, Robert Marko wrote: > > > I will look at IRQ GPIO docs, but in this case, then we have more > > > conversions that > > > are not correct. > > > > Then please point them out. > > Oh, now I get the issue, I was misunderstanding it completely. > gpiochip_enable_irq and gpiochip_disable_irq are not being called > at all. > > However, I dont see them being called before the conversion as well. > I am not really familiar with the PMIC IRQ-s, looked like an easy conversion > to get rid of the warning. They definitely were. Look at how gpiochip_add_data() eventually ends up calling gpiochip_set_irq_hooks((), which hijacks the irq_chip function pointers to insert the calls to these helpers. This is what this conversion process is all about, and you absolutely need to understand that code before blindly changing drivers to squash a run-time warning. M. -- Without deviation from the norm, progress is not possible.