From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42565C433EF for ; Fri, 10 Jun 2022 03:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239767AbiFJDRe (ORCPT ); Thu, 9 Jun 2022 23:17:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbiFJDRa (ORCPT ); Thu, 9 Jun 2022 23:17:30 -0400 Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 04F063B1726 for ; Thu, 9 Jun 2022 20:17:28 -0700 (PDT) Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id C830E2051591; Fri, 10 Jun 2022 12:17:26 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.16.1/8.16.1/Debian-3) with ESMTPS id 25A3HP4Z017165 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 10 Jun 2022 12:17:26 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.16.1/8.16.1/Debian-3) with ESMTPS id 25A3HPaZ089403 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 10 Jun 2022 12:17:25 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.16.1/8.16.1/Submit) id 25A3HOUk089401; Fri, 10 Jun 2022 12:17:24 +0900 From: OGAWA Hirofumi To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Peter Jones , Alexander Larsson , Colin Walters , Alberto Ruiz , Muhammad Usama Anjum , Lennart Poettering , Chung-Chiang Cheng , Christian Kellner , Carlos Maiolino Subject: Re: [PATCH v5 3/4] fat: add renameat2 RENAME_EXCHANGE flag support References: <20220609093638.664034-1-javierm@redhat.com> <20220609093638.664034-4-javierm@redhat.com> <878rq54pf1.fsf@mail.parknet.co.jp> <9d837076-f666-c3c3-dd09-5c3705da23e6@redhat.com> Date: Fri, 10 Jun 2022 12:17:24 +0900 In-Reply-To: <9d837076-f666-c3c3-dd09-5c3705da23e6@redhat.com> (Javier Martinez Canillas's message of "Thu, 9 Jun 2022 22:36:21 +0200") Message-ID: <874k0t437f.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Javier Martinez Canillas writes: >> >> Looks like unnecessary complex (and comparing raw i_mode, not S_ISDIR(), >> better to change before make dir dirty). How about this change, it is >> only tested slightly though? Can you review and test? >> > > Your change looks good to me and indeed the logic is simpler than in mine. > > I've also tested it and AFAICT it works correctly as well. Do you plan to > squash this or should I respin a new revision of the whole patch-set ? If > you want to post it as a follow-up I'm also OK with that. Could you merge to your patchset, and re-send? Thanks. -- OGAWA Hirofumi