From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA8D7C4707F for ; Fri, 28 May 2021 01:20:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 851A96135C for ; Fri, 28 May 2021 01:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235470AbhE1BW2 (ORCPT ); Thu, 27 May 2021 21:22:28 -0400 Received: from regular1.263xmail.com ([211.150.70.201]:33402 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233887AbhE1BWZ (ORCPT ); Thu, 27 May 2021 21:22:25 -0400 Received: from localhost (unknown [192.168.167.32]) by regular1.263xmail.com (Postfix) with ESMTP id A3DDCE93; Fri, 28 May 2021 09:20:50 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 Received: from manjaro.uniontech.com (unknown [58.246.122.242]) by smtp.263.net (postfix) whith ESMTP id P30809T139674035984128S1622164849330166_; Fri, 28 May 2021 09:20:50 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <31ee6ffdcbc1b557f7377d65e9c76b07> X-RL-SENDER: chenli@uniontech.com X-SENDER: chenli@uniontech.com X-LOGIN-NAME: chenli@uniontech.com X-FST-TO: kuba@kernel.org X-RCPT-COUNT: 3 X-SENDER-IP: 58.246.122.242 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 Date: Fri, 28 May 2021 09:20:49 +0800 Message-ID: <874ken1wni.wl-chenli@uniontech.com> From: Chen Li To: Jakub Kicinski Cc: linux-kernel@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH] netlink: simplify NLMSG_DATA with NLMSG_HDRLEN In-Reply-To: <20210527090724.44b0c040@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <878s401w1r.wl-chenli@uniontech.com> <20210527090724.44b0c040@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 May 2021 00:07:24 +0800, Jakub Kicinski wrote: > > On Thu, 27 May 2021 15:21:36 +0800 Chen Li wrote: > > The NLMSG_LENGTH(0) may confuse the API users, > > NLMSG_HDRLEN is much more clear. > > > > Besides, some code style problems are also fixed. > > Signed-off-by: Chen Li > > Looks fine, but you'll need to repost and CC netdev@vger. > > Thanks, done.