Re: [PATCH RFC 2/2] genirq/matrix: WARN_ON_ONCE() when cm->allocated/m->total_allocated go negative

Thomas Gleixner
2021-03-18T19:30:31Z

On Thu, Mar 18 2021 at 08:58, Vitaly Kuznetsov wrote:
> Thomas Gleixner <tglx@linutronix.de> writes:
>> There is a way more useful way to handle this. In such a case the bit is
>> NOT set in the alloc map. So:
>>
>> if (!WARN_ON_ONCE(test_and_clear_bit(bit, cm->alloc_map)))
>> return;
>>
>> would have caught the problem at hand nicely and let the machine survive
>> while just throwing warns and continuing is broken to begin with.
>
> Thanks, I like the idea. I didn't do that probably because the problem
> which triggered me to write these patches wasn't fatal, it was just
> causing CPU0 offlining to fail.

Can you whip up a patch for that?

Thanks,

tglx