From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 426AEC04AA8 for ; Tue, 30 Apr 2019 12:21:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1320820652 for ; Tue, 30 Apr 2019 12:21:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727654AbfD3MVV (ORCPT ); Tue, 30 Apr 2019 08:21:21 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:58381 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726053AbfD3MVU (ORCPT ); Tue, 30 Apr 2019 08:21:20 -0400 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 0616244028D; Tue, 30 Apr 2019 15:21:18 +0300 (IDT) References: <20190430093212.28425-1-alexandre.belloni@bootlin.com> <20190430093212.28425-3-alexandre.belloni@bootlin.com> User-agent: mu4e 1.0; emacs 26.1 From: Baruch Siach To: Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/4] rtc: digicolor: use .set_time In-reply-to: <20190430093212.28425-3-alexandre.belloni@bootlin.com> Date: Tue, 30 Apr 2019 15:21:18 +0300 Message-ID: <874l6fu1j5.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, On Tue, Apr 30 2019, Alexandre Belloni wrote: > Use .set_time instead of the deprecated .set_mmss. > > Signed-off-by: Alexandre Belloni Acked-by: Baruch Siach baruch > --- > drivers/rtc/rtc-digicolor.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c > index e6e16aaac254..ed2fc1adafd5 100644 > --- a/drivers/rtc/rtc-digicolor.c > +++ b/drivers/rtc/rtc-digicolor.c > @@ -106,11 +106,11 @@ static int dc_rtc_read_time(struct device *dev, struct rtc_time *tm) > return 0; > } > > -static int dc_rtc_set_mmss(struct device *dev, unsigned long secs) > +static int dc_rtc_set_time(struct device *dev, struct rtc_time *tm) > { > struct dc_rtc *rtc = dev_get_drvdata(dev); > > - return dc_rtc_write(rtc, secs); > + return dc_rtc_write(rtc, rtc_tm_to_time64(tm)); > } > > static int dc_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm) > @@ -161,7 +161,7 @@ static int dc_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) > > static const struct rtc_class_ops dc_rtc_ops = { > .read_time = dc_rtc_read_time, > - .set_mmss = dc_rtc_set_mmss, > + .set_time = dc_rtc_set_time, > .read_alarm = dc_rtc_read_alarm, > .set_alarm = dc_rtc_set_alarm, > .alarm_irq_enable = dc_rtc_alarm_irq_enable, -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -