From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C19C43387 for ; Fri, 18 Jan 2019 09:42:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31A452086D for ; Fri, 18 Jan 2019 09:42:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727177AbfARJma (ORCPT ); Fri, 18 Jan 2019 04:42:30 -0500 Received: from mx2.suse.de ([195.135.220.15]:46256 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725898AbfARJm3 (ORCPT ); Fri, 18 Jan 2019 04:42:29 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7879EAA5C; Fri, 18 Jan 2019 09:42:28 +0000 (UTC) From: Luis Henriques To: Thomas Gleixner Cc: LKML , Greg Kroah-Hartman , Kate Stewart , Jonathan Corbet , Jiri Kosina , "Yan\, Zheng" , Sage Weil , Ilya Dryomov , ceph-devel@vger.kernel.org Subject: Re: [patch 6/9] ceph: quota: Cleanup license mess References: <20190117231416.111952141@linutronix.de> <20190117231501.346447710@linutronix.de> Date: Fri, 18 Jan 2019 09:42:57 +0000 In-Reply-To: <20190117231501.346447710@linutronix.de> (Thomas Gleixner's message of "Fri, 18 Jan 2019 00:14:22 +0100") Message-ID: <874la6wbby.fsf@suse.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas Gleixner writes: > Precise and non-ambiguous license information is important. The recently > added aegis header file has a SPDX license identifier, which is nice, but > at the same time it has a contradictionary license boiler plate text. > > SPDX-License-Identifier: GPL-2.0 > > versus > > * This program is free software; you can redistribute it and/or > * modify it under the terms of the GNU General Public License > * as published by the Free Software Foundation; either version 2 > * of the License, or (at your option) any later version. > > Oh well. > > As the other ceph related files are licensed under the GPL v2 only, it's > assumed that the SPDX id is correct and the boiler plate was randomly > copied into that patch. > > Remove the boiler plate as it is wrong and even if correct it is redundant. > > Fixes: fb18a57568c2 ("ceph: quota: add initial infrastructure to support cephfs quotas") > Signed-off-by: Thomas Gleixner > Cc: Luis Henriques > Cc: Jiri Kosina > Cc: "Yan, Zheng" > Cc: Sage Weil > Cc: Ilya Dryomov > Cc: ceph-devel@vger.kernel.org Thanks, Thomas. Fell free to add my Acked-by: Luis Henriques Cheers, -- Luis > --- > > P.S.: This patch is part of a larger cleanup, but independent of other > patches and is intended to be picked up by the maintainer directly. > > --- > fs/ceph/quota.c | 13 ------------- > 1 file changed, 13 deletions(-) > > --- a/fs/ceph/quota.c > +++ b/fs/ceph/quota.c > @@ -3,19 +3,6 @@ > * quota.c - CephFS quota > * > * Copyright (C) 2017-2018 SUSE > - * > - * This program is free software; you can redistribute it and/or > - * modify it under the terms of the GNU General Public License > - * as published by the Free Software Foundation; either version 2 > - * of the License, or (at your option) any later version. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - * GNU General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, see . > */ > > #include > > >