From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752256AbdGXA6B (ORCPT ); Sun, 23 Jul 2017 20:58:01 -0400 Received: from mga01.intel.com ([192.55.52.88]:29944 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbdGXA5w (ORCPT ); Sun, 23 Jul 2017 20:57:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,404,1496127600"; d="scan'208";a="128414327" From: "Huang\, Ying" To: Andrew Morton Cc: "Huang\, Ying" , , , Ross Zwisler , , Johannes Weiner , Minchan Kim , Hugh Dickins , Shaohua Li , Rik van Riel , Andrea Arcangeli , "Kirill A . Shutemov" , Jens Axboe , Michal Hocko , Ming Lei Subject: Re: [PATCH -mm -v2 00/12] mm, THP, swap: Delay splitting THP after swapped out References: <20170623071303.13469-1-ying.huang@intel.com> <20170721162129.077f7d9b4c77c8593e47aed9@linux-foundation.org> Date: Mon, 24 Jul 2017 08:57:48 +0800 In-Reply-To: <20170721162129.077f7d9b4c77c8593e47aed9@linux-foundation.org> (Andrew Morton's message of "Fri, 21 Jul 2017 16:21:29 -0700") Message-ID: <874lu2ircj.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton writes: > On Fri, 23 Jun 2017 15:12:51 +0800 "Huang, Ying" wrote: > >> From: Huang Ying >> >> Hi, Andrew, could you help me to check whether the overall design is >> reasonable? >> >> Hi, Johannes and Minchan, Thanks a lot for your review to the first >> step of the THP swap optimization! Could you help me to review the >> second step in this patchset? >> >> Hi, Hugh, Shaohua, Minchan and Rik, could you help me to review the >> swap part of the patchset? Especially [01/12], [02/12], [03/12], >> [04/12], [11/12], and [12/12]. >> >> Hi, Andrea and Kirill, could you help me to review the THP part of the >> patchset? Especially [01/12], [03/12], [07/12], [08/12], [09/12], >> [11/12]. >> >> Hi, Johannes, Michal, could you help me to review the cgroup part of >> the patchset? Especially [08/12], [09/12], and [10/12]. >> >> And for all, Any comment is welcome! > > I guess it's time for a resend. Folks, could we please get some more > review&test going here? Sure. Will resend it ASAP. And Thanks for reminding! >> Because the THP swap writing support patch [06/12] needs to be rebased >> on multipage bvec patchset which hasn't been merged yet. The [06/12] >> in this patchset is just a test patch and will be rewritten later. >> The patchset depends on multipage bvec patchset too. > > Are these dependency issues any simpler now? Ming Lei has sent the v2 of multipage bvec patchset on June 26th. Jens Axboe thinks the patchset will target v4.14. https://lkml.org/lkml/2017/6/26/538 Best Regards, Huang, Ying >> This is the second step of THP (Transparent Huge Page) swap >> optimization. In the first step, the splitting huge page is delayed >> from almost the first step of swapping out to after allocating the >> swap space for the THP and adding the THP into the swap cache. In the >> second step, the splitting is delayed further to after the swapping >> out finished. The plan is to delay splitting THP step by step, >> finally avoid splitting THP for the THP swapping out and swap out/in >> the THP as a whole. >> >> In the patchset, more operations for the anonymous THP reclaiming, >> such as TLB flushing, writing the THP to the swap device, removing the >> THP from the swap cache are batched. So that the performance of >> anonymous THP swapping out are improved. >>