From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752901AbdDCLjC (ORCPT ); Mon, 3 Apr 2017 07:39:02 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35846 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbdDCLi6 (ORCPT ); Mon, 3 Apr 2017 07:38:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9F0CF607EA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Elena Reshetova Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rdma@vger.kernel.org, linux-hams@vger.kernel.org, linux-ppp@vger.kernel.org, linux-wireless@vger.kernel.org, ganeshgr@chelsio.com, nbd@openwrt.org, blogic@openwrt.org, matthias.bgg@gmail.com, yishaih@mellanox.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, ajk@comnets.uni-bremen.de, paulus@samba.org, j@w1.fi, peterz@infradead.org, keescook@chromium.org, gregkh@linuxfoundation.org, Hans Liljestrand , David Windsor Subject: Re: [PATCH 15/16] drivers, net, intersil: convert hostap_cmd_queue.usecnt from atomic_t to refcount_t References: <1490691403-4016-1-git-send-email-elena.reshetova@intel.com> <1490691403-4016-16-git-send-email-elena.reshetova@intel.com> Date: Mon, 03 Apr 2017 14:38:49 +0300 In-Reply-To: <1490691403-4016-16-git-send-email-elena.reshetova@intel.com> (Elena Reshetova's message of "Tue, 28 Mar 2017 11:56:42 +0300") Message-ID: <874ly5oh4m.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Elena Reshetova writes: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > > Signed-off-by: Elena Reshetova > Signed-off-by: Hans Liljestrand > Signed-off-by: Kees Cook > Signed-off-by: David Windsor > --- > drivers/net/wireless/intersil/hostap/hostap_hw.c | 12 ++++++------ > drivers/net/wireless/intersil/hostap/hostap_wlan.h | 3 ++- > 2 files changed, 8 insertions(+), 7 deletions(-) The prefix should be "hostap:", I'll fix that. -- Kalle Valo