From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751175AbdBBIdE (ORCPT ); Thu, 2 Feb 2017 03:33:04 -0500 Received: from mga06.intel.com ([134.134.136.31]:1072 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbdBBIdD (ORCPT ); Thu, 2 Feb 2017 03:33:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,323,1477983600"; d="scan'208";a="816162758" From: Jani Nikula To: Shuah Khan , daniel.vetter@intel.com, seanpaul@chromium.org, airlied@linux.ie Cc: Shuah Khan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: change connector disconnected debug message to an error In-Reply-To: <20170202025904.25810-1-shuahkh@osg.samsung.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170202025904.25810-1-shuahkh@osg.samsung.com> Date: Thu, 02 Feb 2017 10:32:59 +0200 Message-ID: <874m0d0z7o.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Feb 2017, Shuah Khan wrote: > Change drm_helper_probe_single_connector_modes() to print an error to > report connector disconnected status instead of a debug message. > > When this condition occurs, application doesn't know the real error and > reports it as driver lacking support for mode setting. Change it to an > error to make it easier to debug. Please explain what makes this condition an error. Connectors get connected and disconnected, business as usual, why should this be an error? BR, Jani. > > Signed-off-by: Shuah Khan > --- > drivers/gpu/drm/drm_probe_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c > index ac953f0..6472b7f 100644 > --- a/drivers/gpu/drm/drm_probe_helper.c > +++ b/drivers/gpu/drm/drm_probe_helper.c > @@ -282,8 +282,8 @@ int drm_helper_probe_single_connector_modes(struct drm_connector *connector, > dev->mode_config.poll_running = drm_kms_helper_poll; > > if (connector->status == connector_status_disconnected) { > - DRM_DEBUG_KMS("[CONNECTOR:%d:%s] disconnected\n", > - connector->base.id, connector->name); > + DRM_ERROR("[CONNECTOR:%d:%s] disconnected\n", > + connector->base.id, connector->name); > drm_mode_connector_update_edid_property(connector, NULL); > verbose_prune = false; > goto prune; -- Jani Nikula, Intel Open Source Technology Center