From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751924AbcF2Uuy (ORCPT ); Wed, 29 Jun 2016 16:50:54 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38027 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751703AbcF2Uuw (ORCPT ); Wed, 29 Jun 2016 16:50:52 -0400 X-IBM-Helo: d24dlp01.br.ibm.com X-IBM-MailFrom: krisman@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org From: Gabriel Krisman Bertazi To: Frank Haverkamp Cc: gregkh@linuxfoundation.org, sebott@linux.vnet.ibm.com, geliangtang@163.com, linux-kernel@vger.kernel.org, bhelgaas@google.com, esa@linux.vnet.ibm.com, breno.leitao@gmail.com, schwidefsky@de.ibm.com Subject: Re: [PATCH] GenWQE: Change default access rights for device node Organization: IBM References: <20160629134743.12424-1-haver@linux.vnet.ibm.com> <20160629134743.12424-2-haver@linux.vnet.ibm.com> Date: Wed, 29 Jun 2016 17:50:45 -0300 In-Reply-To: <20160629134743.12424-2-haver@linux.vnet.ibm.com> (Frank Haverkamp's message of "Wed, 29 Jun 2016 15:47:43 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062920-0028-0000-0000-0000011D98EA X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062920-0029-0000-0000-000013C27211 Message-Id: <874m8bpvmi.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-29_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606290192 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Frank Haverkamp writes: > Since it should always be ok for normal users to operate the accelerator, > it makes sense to change it in our driver, rather than adding udev rules > for all Linux distributions. > > Signed-off-by: Frank Haverkamp Reviewed-by: Gabriel Krisman Bertazi > --- > drivers/misc/genwqe/card_base.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c > index 4cf8f82..768a057 100644 > --- a/drivers/misc/genwqe/card_base.c > +++ b/drivers/misc/genwqe/card_base.c > @@ -1355,6 +1355,19 @@ static struct pci_driver genwqe_driver = { > }; > > /** > + * genwqe_devnode() - Set default access mode for genwqe devices. > + * > + * Default mode should be rw for everybody. Do not change default > + * device name. > + */ > +static char *genwqe_devnode(struct device *dev, umode_t *mode) > +{ > + if (mode) > + *mode = 0666; > + return NULL; > +} > + > +/** > * genwqe_init_module() - Driver registration and initialization > */ > static int __init genwqe_init_module(void) > @@ -1367,6 +1380,8 @@ static int __init genwqe_init_module(void) > return -ENOMEM; > } > > + class_genwqe->devnode = genwqe_devnode; > + > debugfs_genwqe = debugfs_create_dir(GENWQE_DEVNAME, NULL); > if (!debugfs_genwqe) { > rc = -ENOMEM; -- Gabriel Krisman Bertazi