From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757588AbcEDH7w (ORCPT ); Wed, 4 May 2016 03:59:52 -0400 Received: from mga14.intel.com ([192.55.52.115]:59732 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbcEDH7v (ORCPT ); Wed, 4 May 2016 03:59:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,575,1455004800"; d="asc'?scan'208";a="798444812" From: Felipe Balbi To: Rajesh Bhagat , linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, leoyang.li@nxp.com, sriram.dash@nxp.com, Rajesh Bhagat Subject: Re: [PATCH] drivers: usb: dwc3 : Configure DMA properties and ops from DT In-Reply-To: <1462333318-29772-1-git-send-email-rajesh.bhagat@nxp.com> References: <1462333318-29772-1-git-send-email-rajesh.bhagat@nxp.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Wed, 04 May 2016 10:57:42 +0300 Message-ID: <874maefe6h.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Rajesh Bhagat writes: > On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly set > to be able to do DMA allocations, so use the of_dma_configure() helper > to populate the dma properties and assign an appropriate dma_ops. > > Signed-off-by: Rajesh Bhagat > Reviewed-by: Yang-Leo Li Cool, nxp is also using dwc3 :-) C'mon Rajesh, send us a glue layer :) > diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c > index c679f63..4d5b783 100644 > --- a/drivers/usb/dwc3/host.c > +++ b/drivers/usb/dwc3/host.c > @@ -17,6 +17,7 @@ >=20=20 > #include > #include > +#include >=20=20 > #include "core.h" >=20=20 > @@ -32,6 +33,9 @@ int dwc3_host_init(struct dwc3 *dwc) > return -ENOMEM; > } >=20=20 > + if (IS_ENABLED(CONFIG_OF) && dwc->dev->of_node) > + of_dma_configure(&xhci->dev, dwc->dev->of_node); okay, so we have a long discussion about this going on. You can catch up with it starting here: http://marc.info/?i=3D1461612094-30939-1-git-send-email-grygorii.strashko@t= i.com At least for now, this patch will be applied. We need to have a better solution for this, one that helps not only DT platforms. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXKat2AAoJEIaOsuA1yqREEOoP/2nwntCHGvAZwyF55crbdVtO qXsuq2K553WMSN0uQYVpUWnjIylATdDvmKuPQ7t5CPQidwtGE59CjaBR41lr6bEE VMYwGV3SSQNGhrRanon4UgphhSwlff/C0eNfzSz/sGUj1AOkB2rymRCs0mTqCzs4 U2z4+ZNAazmomnfkIHYw3dN/vnhnmeHewJhPhJwbTZx7uvXKL0TyW10xU26lBFN4 CFtDOxKcaX+5GqjJ/n2bWxoJROUhuGILJpGJUN6FDuQdgdPHXPyU7DNKd3A0ofMW 4hDfUrUaFEk2Bizy7ugbqxl2HUjb3XTci47+HfZDf9K6/I0YlsObpdutXkVwslfo oSgmbHH3O2Q9reDNqzAo+lWbIrKp4CPgEK1z4b2H7tzNEobqGRQ5wd+nUPLoNfFj vVzEwtQ5oC0AMQcOpbdCUUNGUrCxcdXIqeXDB3BBm6yrH+8VUX61XnN4FkEK9Pf7 A8PPYu6QMHAx09hNA+68Oqc0eUf7ZwPLo+zXcvPcRJVtV4qC8Wc/BUgUVe4YpFND R0veZYQZJHhN0A7wK4jl4IPliQ1RBh7vVcyt2uQqVpQfILySpLOM7WSckVdCs3wI MBlIwS8Sh4GJNUq+cY4A32SLrOGG8k4QW1ooynGaQ8C+gfmcCpmv4hBO+T6yE+Pt mKbeVf106r8oZFgLxSFY =kimL -----END PGP SIGNATURE----- --=-=-=--