public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	stable <stable@vger.kernel.org>,
	Pontus Fuchs <pontus.fuchs@gmail.com>
Subject: Re: [PATCH] module: Call module notifier on failure after complete_formation()
Date: Sat, 09 May 2015 03:26:18 +0930	[thread overview]
Message-ID: <874mnnlzr1.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20150508112248.2ce5af16@gandalf.local.home>

Steven Rostedt <rostedt@goodmis.org> writes:
> On Fri, 8 May 2015 11:17:36 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> 
>> The module notifier call chain for MODULE_STATE_COMING was moved up before
>> the parsing of args, into the complete_formation() call. But if the module failed
>> to load after that, the notifier call chain for MODULE_STATE_GOING was
>> never called and that prevented the users of those call chains from
>> cleaning up anything that was allocated.
>> 
>> Link: http://lkml.kernel.org/r/554C52B9.9060700@gmail.com
>
> You can nuke the "Link". I didn't realize Pontus didn't Cc any mailing
> lists, and I manually just added it. Usually my scripts will check if
> lkml was Cc'd and only add the "Link" tag if it was. Just shows you
> that my scripts are smarter than I am.

Thanks for this.

Applied,
Rusty.

      reply	other threads:[~2015-05-09  0:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 15:17 [PATCH] module: Call module notifier on failure after complete_formation() Steven Rostedt
2015-05-08 15:22 ` Steven Rostedt
2015-05-08 17:56   ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mnnlzr1.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pontus.fuchs@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox