From: Kevin Hilman <khilman@linaro.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Robin Holt <holt@sgi.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andrey Konovalov <andrey.konovalov@linaro.org>,
Russ Anderson <rja@sgi.com>, Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org,
Milosz Wasilewski <milosz.wasilewski@linaro.org>
Subject: Re: linux-next: panda build failed at arch/arm/mach-omap2/omap4-restart.c
Date: Tue, 25 Jun 2013 14:42:24 -0700 [thread overview]
Message-ID: <874ncluatb.fsf@linaro.org> (raw)
In-Reply-To: <CA+G9fYupw8Gi=5p2nKVJ9GqfhwBcTw7hyzGA8+K+gHmdL96mJg@mail.gmail.com> (Naresh Kamboju's message of "Tue, 25 Jun 2013 22:46:02 +0530")
Naresh Kamboju <naresh.kamboju@linaro.org> writes:
> ping
This is a known issue[1] and already has some proposed fixes, they are just
not merged yet.
Kevin
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-June/178209.html
> On 23 June 2013 13:53, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>> Hi,
>>
>> panda build broken on linux-next branch
>>
>> kernel_config=omap2plus_defconfig
>> KERNEL_VERSION=3.10.0-rc6
>> KERNEL_GIT=git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>> KERNEL_COMMIT=e1a86578747376f08985627c84df088a5d0d1e92
>>
>> Build error log :
>> -------------------
>> 04:43:18 CC arch/arm/mach-omap2/omap4-restart.o
>> 04:43:18 /mnt/ci_build/workspace/linux-next/hwpack/panda/label/kernel_cloud/arch/arm/mach-omap2/omap4-restart.c:21:28:
>> warning: ‘enum reboot_mode’ declared inside parameter list [enabled by
>> default]
>> 04:43:18 void omap44xx_restart(enum reboot_mode mode, const char *cmd)
>> 04:43:18 ^
>> 04:43:18 /mnt/ci_build/workspace/linux-next/hwpack/panda/label/kernel_cloud/arch/arm/mach-omap2/omap4-restart.c:21:28:
>> warning: its scope is only this definition or declaration, which is
>> probably not what you want [enabled by default]
>> 04:43:18 /mnt/ci_build/workspace/linux-next/hwpack/panda/label/kernel_cloud/arch/arm/mach-omap2/omap4-restart.c:21:40:
>> error: parameter 1 (‘mode’) has incomplete type
>> 04:43:18 void omap44xx_restart(enum reboot_mode mode, const char *cmd)
>> 04:43:18 ^
>> 04:43:18 /mnt/ci_build/workspace/linux-next/hwpack/panda/label/kernel_cloud/arch/arm/mach-omap2/omap4-restart.c:21:6:
>> warning: function declaration isn’t a prototype [-Wstrict-prototypes]
>> 04:43:18 void omap44xx_restart(enum reboot_mode mode, const char *cmd)
>> 04:43:18 ^
>> 04:43:18 make[2]: *** [arch/arm/mach-omap2/omap4-restart.o] Error 1
>> 04:43:18 make[1]: *** [arch/arm/mach-omap2] Error 2
>>
>> Full build log:
>> ------------------
>> https://ci.linaro.org/jenkins/job/linux-next/hwpack=panda,label=kernel_cloud/lastBuild/console
>>
>> Suspecting patch which caused build failed:
>> --------------------------------------------------------
>> commit b61cdf2aebc5cd2f4efc4e0cbebeb8a91884a43e
>> Author: Robin Holt <holt@sgi.com>
>> Date: Wed Jun 19 10:08:43 2013 +1000
>>
>> reboot: arm: change reboot_mode to use enum reboot_mode
>>
>> Preparing to move the parsing of reboot= to generic kernel code forces the
>> change in reboot_mode handling to use the enum.
>>
>> Signed-off-by: Robin Holt <holt@sgi.com>
>>
>> ...
>> diff --git a/arch/arm/mach-omap2/omap4-restart.c
>> b/arch/arm/mach-omap2/omap4-restart.c
>> index f90e02e..652adde 100644
>> --- a/arch/arm/mach-omap2/omap4-restart.c
>> +++ b/arch/arm/mach-omap2/omap4-restart.c
>> @@ -18,7 +18,7 @@
>> * Resets the SoC. For @cmd, see the 'reboot' syscall in
>> * kernel/sys.c. No return value.
>> */
>> -void omap44xx_restart(char mode, const char *cmd)
>> +void omap44xx_restart(enum reboot_mode mode, const char *cmd)
>> {
>> /* XXX Should save 'cmd' into scratchpad for use after reboot */
>> omap4_prminst_global_warm_sw_reset(); /* never returns */
>> ...
>>
>> Best regards
>> Naresh Kamboju
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-06-25 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 8:23 linux-next: panda build failed at arch/arm/mach-omap2/omap4-restart.c Naresh Kamboju
2013-06-25 17:16 ` Naresh Kamboju
2013-06-25 21:42 ` Kevin Hilman [this message]
2013-07-01 8:14 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ncluatb.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=andrey.konovalov@linaro.org \
--cc=holt@sgi.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=milosz.wasilewski@linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=rja@sgi.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox