From: Rusty Russell <rusty@rustcorp.com.au>
To: Chen Gang <gang.chen@asianux.com>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] kernel: module: using strlcpy and strcpy instead of strncpy
Date: Wed, 10 Apr 2013 16:22:28 +0930 [thread overview]
Message-ID: <874nfe7u8j.fsf@rustcorp.com.au> (raw)
In-Reply-To: <5164E6EC.1010803@asianux.com>
Chen Gang <gang.chen@asianux.com> writes:
> namebuf is NUL terminated string. better always let it ended by '\0'.
>
> the module_name() is always the name field of struct module (which is
> a fixed array), or a literal "kernel", so strcpy is better.
Thanks, applied.
Cheers,
Rusty.
prev parent reply other threads:[~2013-04-10 10:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 11:38 [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy Chen Gang
2013-04-07 14:28 ` Geert Uytterhoeven
2013-04-08 2:48 ` Chen Gang
2013-04-08 3:02 ` Chen Gang
2013-04-08 5:30 ` Rusty Russell
2013-04-08 10:16 ` Chen Gang
2013-04-08 13:45 ` Rusty Russell
2013-04-09 1:52 ` Chen Gang
2013-04-09 9:36 ` Chen Gang
2013-04-09 9:55 ` Chen Gang
2013-04-10 6:00 ` Chen Gang
2013-04-09 2:47 ` [PATCH v2] kernel: module: using strlcpy and strcpy " Chen Gang
2013-04-10 1:22 ` Rusty Russell
2013-04-10 4:13 ` [PATCH v3] " Chen Gang
2013-04-10 6:52 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nfe7u8j.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox