From: Sven Joachim <svenjoac@gmx.de>
To: jlec@gentoo.org
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kconfig: use config scripts to detect ncurses libs
Date: Thu, 28 Feb 2013 22:50:45 +0100 [thread overview]
Message-ID: <874ngwhzuy.fsf@turtle.gmx.de> (raw)
In-Reply-To: <1362045557-9123-1-git-send-email-jlec@gentoo.org> (jlec@gentoo.org's message of "Thu, 28 Feb 2013 10:59:17 +0100")
On 2013-02-28 10:59 +0100, jlec@gentoo.org wrote:
> Ncurses provides a config script (ncurses5-config) to assist finding ncurses.
> This patch makes use of it to detect the necessary libs for linking of the
> ncurses nconfig dialog.
That script is not necessarily called ncurses5-config, it might also be
called ncurses6-config is ncurses is configured for a different ABI
(--enable-ext-colors, --enable-ext-mouse). Although I would suspect
that any distribution who does that provides a compatibility symlink.
> scripts/kconfig/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> index 3091794..c372976 100644
> --- a/scripts/kconfig/Makefile
> +++ b/scripts/kconfig/Makefile
> @@ -216,7 +216,9 @@ HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \
>
> HOSTLOADLIBES_mconf = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
>
> -HOSTLOADLIBES_nconf = -lmenu -lpanel -lncurses
> +HOSTLOADLIBES_nconf = -lmenu -lpanel
> +HOSTLOADLIBES_nconf += $(shell ncursesw5-config --libs 2>/dev/null \
> + || ncurses5-config --libs 2>/dev/null )
This will link with ncursesw, not ncurses. Probably not what you want,
since nconf.h does not #include the right headers for that.
On Debian/Ubuntu, there's also the problem that ncursesw5-config exists
even if the libncursesw5-dev package is not installed, so this patch
makes the build fail in such cases.
Can we just call ncurses5-config and not ncursesw5-config, or are there
any distros who ship the latter and not the former?
Cheers,
Sven
next prev parent reply other threads:[~2013-02-28 21:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 9:59 [PATCH 2/2] kconfig: use config scripts to detect ncurses libs jlec
2013-02-28 20:59 ` Yann E. MORIN
2013-03-01 7:48 ` justin
2013-02-28 21:50 ` Sven Joachim [this message]
2013-03-01 7:37 ` justin
2013-03-01 8:36 ` Sven Joachim
2013-03-01 13:47 ` justin
2013-03-01 17:04 ` Sven Joachim
2013-03-03 20:23 ` Yann E. MORIN
2013-03-03 21:37 ` Sven Joachim
-- strict thread matches above, loose matches on Subject: below --
2013-03-01 15:50 ncurses detection for nconfig/menuconfig patches revised jlec
2013-03-01 15:50 ` [PATCH 2/2] kconfig: use config scripts to detect ncurses libs jlec
2013-03-03 20:38 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ngwhzuy.fsf@turtle.gmx.de \
--to=svenjoac@gmx.de \
--cc=jlec@gentoo.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox