From: ebiederm@xmission.com (Eric W. Biederman)
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: acme@ghostprotocols.net, davem@davemloft.net,
bhutchings@solarflare.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to
Date: Tue, 07 Aug 2012 07:25:07 -0700 [thread overview]
Message-ID: <874noeeq4c.fsf@xmission.com> (raw)
In-Reply-To: <1344348020-4966-1-git-send-email-ahiliation@yahoo.co.in> (Jeffrin Jose's message of "Tue, 7 Aug 2012 19:30:20 +0530")
Jeffrin Jose <ahiliation@yahoo.co.in> writes:
> case TIOCINQ: {
> /*
> * These two are safe on a single CPU system as only
> * user tasks fiddle here
> */
> - struct sk_buff *skb = skb_peek(&sk->sk_receive_queue);
> - long amount = 0;
> + struct sk_buff *skb = skb_peek(&sk->sk_receive_queue);
> + long amount = 0;
>
> - if (skb)
> - amount = skb->len - sizeof(struct ddpehdr);
> + if (skb)
> + amount = skb->len - sizeof(struct ddpehdr);
> rc = put_user(amount, (int __user *)argp);
> break;
> }
Is putting "rc = put_user(amount, (int __user *)argp);" on the same
indentation level as "amount = skb->len - sizeof(struct ddpehdr);"
really what you want to do?
Eric
next prev parent reply other threads:[~2012-08-07 14:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 14:00 [PATCH] net:appletalk:ddp:fixed coding style issue again relating to Jeffrin Jose
2012-08-07 14:25 ` Eric W. Biederman [this message]
2012-08-07 21:46 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-08-07 14:57 Jeffrin Jose
2012-08-07 16:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874noeeq4c.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=acme@ghostprotocols.net \
--cc=ahiliation@yahoo.co.in \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox