From: ebiederm@xmission.com (Eric W. Biederman)
To: Glauber Costa <glommer@parallels.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Thelen <gthelen@google.com>,
Serge Hallyn <serge.hallyn@canonical.com>,
Tejun Heo <tj@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] fail dentry revalidation after namespace change
Date: Fri, 06 Jul 2012 02:51:02 -0700 [thread overview]
Message-ID: <874npli5fd.fsf@xmission.com> (raw)
In-Reply-To: <4FF6B37B.4040005@parallels.com> (Glauber Costa's message of "Fri, 6 Jul 2012 13:44:27 +0400")
Glauber Costa <glommer@parallels.com> writes:
> On 07/06/2012 01:37 PM, Eric W. Biederman wrote:
>> Glauber Costa <glommer@parallels.com> writes:
>>
>>> When we change the namespace tag of a sysfs entry, the associated dentry
>>> is still kept around. readdir() will work correctly and not display the
>>> old entries, but open() will still succeed, so will reads and writes.
>>
>> Note reads and writes of file handles open before the move should
>> continue to work.
>
> Well, yes. But do you see it as a big problem?
>
> This can probably be fixed as well, but I foresee a big hackishness in
> the way =p
At the moment it looks like a feature.
The only reason we bounce between different instances of sysfs is
because of the unfortunate sysfs directory layout that we need
to remain compatible with.
But I don't see it making much of a difference either way.
Eric
next prev parent reply other threads:[~2012-07-06 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 9:09 [PATCH v2] fail dentry revalidation after namespace change Glauber Costa
2012-07-06 9:37 ` Eric W. Biederman
2012-07-06 9:44 ` Glauber Costa
2012-07-06 9:51 ` Eric W. Biederman [this message]
2012-07-09 23:13 ` Andrew Morton
2012-07-09 23:43 ` Serge Hallyn
2012-07-10 0:30 ` Eric W. Biederman
2012-07-10 0:47 ` Andrew Morton
2012-07-10 1:51 ` Eric W. Biederman
2012-07-10 2:15 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874npli5fd.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=glommer@parallels.com \
--cc=gregkh@linuxfoundation.org \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox