* [patch] missing dependency for virtio_mmio
@ 2011-11-21 3:58 Al Viro
2011-11-21 5:26 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Al Viro @ 2011-11-21 3:58 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Rusty Russell, linux-kernel
Driver really depends on having readb/writeb/etc. - won't even build on
things like s390 or uml and on tile without PCI it'll build but panic
if you manage to run it...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index 816ed08..4ae52fc 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -37,7 +37,7 @@ config VIRTIO_BALLOON
config VIRTIO_MMIO
tristate "Platform bus driver for memory mapped virtio devices (EXPERIMENTAL)"
- depends on EXPERIMENTAL
+ depends on EXPERIMENTAL && HAS_IOMEM
select VIRTIO
select VIRTIO_RING
---help---
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] missing dependency for virtio_mmio
2011-11-21 3:58 [patch] missing dependency for virtio_mmio Al Viro
@ 2011-11-21 5:26 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2011-11-21 5:26 UTC (permalink / raw)
To: Al Viro, Linus Torvalds; +Cc: linux-kernel
On Mon, 21 Nov 2011 03:58:31 +0000, Al Viro <viro@ZenIV.linux.org.uk> wrote:
> Driver really depends on having readb/writeb/etc. - won't even build on
> things like s390 or uml and on tile without PCI it'll build but panic
> if you manage to run it...
Thanks, already queued. I was about to send it when YA virtio fix
turned up, and I like them to sit in linux-next for a cycle first.
That said, happy for Linus to take this now if it's breaking people.
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-21 6:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-21 3:58 [patch] missing dependency for virtio_mmio Al Viro
2011-11-21 5:26 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox