* [PATCH] binfmt_flat: missing argv table
@ 2011-06-15 7:30 Yoshinori Sato
2011-06-15 15:52 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Yoshinori Sato @ 2011-06-15 7:30 UTC (permalink / raw)
To: uclinux-dev, linux-kernel
"put_user" is multiple times evalute on argument
(in asm-generic/uaccess.h).
So this code building argv table include gabage.
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
index 811384b..127a198 100644
--- a/fs/binfmt_flat.c
+++ b/fs/binfmt_flat.c
@@ -144,7 +144,7 @@ static unsigned long create_flat_tables(
put_user(argc, sp);
current->mm->arg_start = (unsigned long) p;
while (argc-->0) {
- put_user((unsigned long) p, argv++);
+ put_user((unsigned long) p, argv); argv++;
do {
get_user(dummy, p); p++;
} while (dummy);
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] binfmt_flat: missing argv table
2011-06-15 7:30 [PATCH] binfmt_flat: missing argv table Yoshinori Sato
@ 2011-06-15 15:52 ` Mike Frysinger
2011-06-17 6:58 ` Yoshinori Sato
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2011-06-15 15:52 UTC (permalink / raw)
To: ysato; +Cc: linux-kernel, uClinux development list
On Wed, Jun 15, 2011 at 03:30, Yoshinori Sato wrote:
> "put_user" is multiple times evalute on argument
> (in asm-generic/uaccess.h).
> So this code building argv table include gabage.
NAK. asm-generic/uaccess.h is broken. i posted some fixes some time
ago to lkml for the header to clean it all up, but it had some minor
build warnings that needed to be addressed.
if you want to actually fix this issue, please start with my patch and
get the issues around it resolved:
asm-generic: uaccess: do not expand args multiple times
-mike
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] binfmt_flat: missing argv table
2011-06-15 15:52 ` Mike Frysinger
@ 2011-06-17 6:58 ` Yoshinori Sato
0 siblings, 0 replies; 3+ messages in thread
From: Yoshinori Sato @ 2011-06-17 6:58 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-kernel, uClinux development list
At Wed, 15 Jun 2011 11:52:33 -0400,
Mike Frysinger wrote:
>
> On Wed, Jun 15, 2011 at 03:30, Yoshinori Sato wrote:
> > "put_user" is multiple times evalute on argument
> > (in asm-generic/uaccess.h).
> > So this code building argv table include gabage.
>
> NAK. asm-generic/uaccess.h is broken. i posted some fixes some time
> ago to lkml for the header to clean it all up, but it had some minor
> build warnings that needed to be addressed.
>
> if you want to actually fix this issue, please start with my patch and
> get the issues around it resolved:
> asm-generic: uaccess: do not expand args multiple times
> -mike
OK.
I found it. and trying cleanup.
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-17 6:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-15 7:30 [PATCH] binfmt_flat: missing argv table Yoshinori Sato
2011-06-15 15:52 ` Mike Frysinger
2011-06-17 6:58 ` Yoshinori Sato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox