Re: [PATCH v6] fat: Batched discard support for fat

OGAWA Hirofumi
2011-05-24T12:19:52Z

Lukas Czerner <lczerner@redhat.com> writes:

>> Are you read my email? So, FAT adjust 2 blocks, ext* 1 block, and what
>> is other? The middle was guaranteed as continued? So, which is end of
>> blocks?
>
> I am sorry but I am not sure what you are asking for. Just grab the size
> of the file system or even better the size of underlying device (since
> the filesyste would not be bigger than that) and use that.
>
> Of course if you grab the count of filesystem blocks (and the file
> system does not account for the first data block) you'll end up with len
> smaller than first data block. So it might make sense to not to
> decrement the len and just start from first data block since it is not
> accounted for anyway. However it is not a big deal, is it ? Are you
> expecting any problems with this behaviour ?

What is size of file system or underlying devices? You force to find the
device which target FS is using? Even if you can get size of underlying
devices, you force to user to insane loop in size of devices?

Why can you guarantee it's not big deal in design? Why can't you admit
userland can't make optimized loop?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>