Re: [PATCH v6] fat: Batched discard support for fat

OGAWA Hirofumi
2011-05-24T09:45:06Z

Kyungmin Park <kmpark@infradead.org> writes:

>>> No, length is not changed. so max-length is used.
>>
>> No, no. Userland will know max-length from statvfs, right? So, let's
>> assume it is 100 (->f_blocks) * 1024 (->f_bsize).
>>
>> Now, userland know about max length, 102400, ok? Let's start to trim.
>>
>> Assume, userland want to trim whole. So, userland will specify like
>>
>>        trim(0, 102400).
>>
>> What happen in kernel actually?
>>
>> Current implement doesn't map blocks. So, in the case of FAT, it adjusts
>> from 0 to 2 * 1024.
>>
>> So, it trims between 2048 and 102400. The problem is here. FS layout is
>> actually, 2048 and (102400 + 2048). I.e. actually userland has to do
>>
>>        trim(2048, 102400 + 2048)
>
> Umm maybe first implementation does as like this, but Lukas mentioned
> it's wrong. So I modified it for batched discard concept.

I don't know what Lukas thought/said though, I hope he notices the
problem if real app started to use. Or I'd like to know how to work
without the knowledge of FS internal.

> You want the loop like this
>
> for (count = start; count <= (start + len); count++)

I'm not sure this loop is what doing from the above example. Like I said
in previous thread, I'd like to see liner mapping from 0 like simply
regular file in _all_FSes_. If I read ext* correctly, it was hell of raw
FS layout.

I.e. FAT has from "2 - (2 + number_of_blocks)" layout, in FAT case, I
think it should map to "0 to number_of_block", and expose as liner from 0.

But, it should be for all FSes, otherwise there is no benefit for
userland. If there is exception, userland would has to know FS internal
after all.

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>