Re: [PATCH v6] fat: Batched discard support for fat

Kyungmin Park
2011-03-29T06:42:09Z

On Tue, Mar 29, 2011 at 3:37 PM, OGAWA Hirofumi
<hirofumi@mail.parknet.co.jp> wrote:
> Kyungmin Park <kmpark@infradead.org> writes:
>
>>> Again, this ioctl's design is unclear, and seems to be strange. I
>>> wouldn't want to add this before clearing it. Please explain what is
>>> right behavior.
>>
>> Umm it's out of my scope. it's trim design.
>> See also btrfs batched discard support. it's also no consideration as
>> you mentioned.
>>
>> As I know, now xfs, ext4, and btrfs support this fstrim without these concern.
>>
>> http://thread.gmane.org/gmane.comp.file-systems.btrfs/9758
>
> I looked at fstrim.c. It is lowlevel tools to just issue FITRIM - it
> doesn't use the result at all.
>
> Um. Honestly I'd like to see more or wait until real user for now,
> instead of providing unclear design.

You can find the testcase xfs251(?)

and it's our our usage. After UMS support finished, execute the trim
command from 0 to MAXINT.
and periodically call the trim FAT partitions.

Thank you,
Kyungmin Park

>
> Thanks.
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>