From: Andi Kleen <andi@firstfloor.org>
To: Kees Cook <kees.cook@canonical.com>
Cc: x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Alexander Potashev <aspotashev@gmail.com>,
Tim Abbott <tabbott@ksplice.com>, Sam Ravnborg <sam@ravnborg.org>,
Jan Beulich <jbeulich@novell.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] x86: clear XD_DISABLED flag on Intel to regain NX
Date: Sat, 19 Jun 2010 10:21:29 +0200 [thread overview]
Message-ID: <874ogzph4m.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20100619055010.GR24749@outflux.net> (Kees Cook's message of "Fri, 18 Jun 2010 22:50:10 -0700")
Kees Cook <kees.cook@canonical.com> writes:
> This will clear the MSR_IA32_MISC_ENABLE_XD_DISABLE bit so that NX cannot
> be inappropriately controlled by the BIOS on Intel CPUs. If NX actually
> needs to be disabled, "noexec=off" can be used.
The patch still seems like a bad idea to me. What happens if
the NX bit is broken for some reason and the BIOS is right
to disable it?
If there's some VM which doesn't ignore unknown MSR writes
it could also break early, and at best you get an ugly
message and at worst a crash.
Do you have evidence for a lot of systems where NX is disabled
this way without BIOS option? Really such information
should be in the patch description.
If you really need to apply it apply it in some place where
exception handling is possible at least.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-06-19 8:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-19 5:50 [PATCH v2 0/4] x86: clear XD_DISABLED flag on Intel to regain NX Kees Cook
2010-06-19 5:51 ` [PATCH 1/4] x86: rename verify_cpu_64.S to verify_cpu.S Kees Cook
2010-06-19 5:52 ` [PATCH 2/4] x86: clear XD_DISABLED flag on Intel to regain NX Kees Cook
2010-06-19 5:52 ` [PATCH 3/4] x86: call verify_cpu during 32bit CPU startup Kees Cook
2010-06-19 5:53 ` [PATCH 4/4] x86: only CPU features determine NX capabilities Kees Cook
2010-06-19 8:21 ` Andi Kleen [this message]
2010-06-19 15:16 ` [PATCH v2 0/4] x86: clear XD_DISABLED flag on Intel to regain NX Arjan van de Ven
2010-06-19 17:54 ` Kees Cook
2010-06-19 18:08 ` H. Peter Anvin
2010-06-19 16:21 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ogzph4m.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=aspotashev@gmail.com \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kees.cook@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sam@ravnborg.org \
--cc=tabbott@ksplice.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox