public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Samuel Tardieu <sam@rfc1149.net>
To: linux-kernel@vger.kernel.org
Subject: Re: Is gcc thread-unsafe?
Date: Thu, 25 Oct 2007 11:40:22 +0200	[thread overview]
Message-ID: <874pgf1qih.fsf@willow.rfc1149.net> (raw)
In-Reply-To: 200710251447.51370.nickpiggin@yahoo.com.au

>>>>> "Nick" == Nick Piggin <nickpiggin@yahoo.com.au> writes:

Nick> Hi David, [BTW. can you retain cc lists, please?]

Nick> On Thursday 25 October 2007 14:29, David Schwartz wrote:
>> > Well that's exactly right. For threaded programs (and maybe even
>> > real-world non-threaded ones in general), you don't want to be >
>> even _reading_ global variables if you don't need to. Cache misses
>> > and cacheline bouncing could easily cause performance to
>> completely > tank in some cases while only gaining a cycle or two
>> in > microbenchmarks for doing these funny x86 predication things.
>> 
>> For some CPUs, replacing an conditional branch with a conditional
>> move is a *huge* win because it cannot be mispredicted.

Nick> A *conditional* store should no be a problem.

Nick> However the funny trick of doing this conditional add
Nick> (implemented with unconditional store), is what is going to
Nick> cause breakage.

Nick> On the CPUs where predicated instructions are a big win, I'd
Nick> expect they should also implement a conditional store for use
Nick> here. However they might be slower than an unconditional store
Nick> (eg. x86's cmov), and in those cases, gcc might just do the
Nick> non-conditional store.


>> In general, compilers should optimize for unshared data since
>> that's much more common in typical code.  Even for shared data, the
>> usual case is that you are going to access the data few times, so
>> pulling the cache line to the CPU is essentially free since it will
>> happen eventually.

Nick> This is not just a question of data that you were going to use
Nick> anyway.  gcc generates memory accesses to locations that would
Nick> never be accessed Even stores. It is basically impossible to say
Nick> that this is a real performance win. Even on single threaded
Nick> code: consider that cache misses take the vast majority of time
Nick> in many loads, which gives a little hint that maybe it's a bad
Nick> idea to do this ;)


>> Heuristics may show that the vast majority of such constructs write
>> anyway.  So the optimization may also be valid based on such
>> heuristics.

Nick> I'd never say the optimisation would always be useless. But it's
Nick> a nasty thing to have on by default, and apparently even with no
Nick> good way to supress it even if we want to.


>> A better question is whether it's legal for a compiler that claims
>> to support POSIX threads. I'm going to post on
>> comp.programming.threads, where the threading experts hang out.

Nick> Either way, I think we really need a way to turn it off for
Nick> Linux.

-- 
Samuel Tardieu -- sam@rfc1149.net -- http://www.rfc1149.net/


  reply	other threads:[~2007-10-25  9:45 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25  3:24 Is gcc thread-unsafe? Nick Piggin
2007-10-25  3:46 ` Arjan van de Ven
2007-10-25  3:58   ` Nick Piggin
2007-10-25  4:29     ` David Schwartz
2007-10-25  4:35       ` Arjan van de Ven
2007-10-25 18:45         ` Måns Rullgård
2007-10-25  4:47       ` Nick Piggin
2007-10-25  9:40         ` Samuel Tardieu [this message]
2007-10-25  9:44         ` Samuel Tardieu
2007-10-25  9:54           ` Samuel Tardieu
2007-10-25  9:55           ` Andi Kleen
2007-10-25  7:15 ` Andi Kleen
2007-10-25 11:58   ` linux-os (Dick Johnson)
2007-10-25 12:16     ` Andi Kleen
2007-10-25 22:49   ` Nick Piggin
2007-10-25 23:09     ` Andi Kleen
2007-10-25 23:14       ` Linus Torvalds
2007-10-25 23:16         ` Andi Kleen
2007-10-25 23:32           ` Linus Torvalds
2007-10-25 23:42             ` Andi Kleen
2007-10-25 23:57               ` Linus Torvalds
2007-10-26  1:15                 ` Zachary Amsden
2007-10-26  4:57               ` Willy Tarreau
2007-10-25 23:43       ` Nick Piggin
2007-10-25 23:55         ` Andi Kleen
2007-10-25 23:57           ` Nick Piggin
2007-10-25 14:55 ` Linus Torvalds
2007-10-25 15:12   ` Pekka Enberg
2007-10-25 21:42   ` David Schwartz
2007-10-25 23:22     ` Nick Piggin
2007-10-26 11:59       ` Andrew Haley
2007-10-26 17:39         ` Chris Friesen
2007-10-26 11:59       ` Andrew Haley
2007-10-25 22:26   ` Ismail Dönmez
2007-10-25 22:56     ` Jeff Garzik
2007-10-25 23:04       ` Jeff Garzik
2007-10-31 22:10 ` Phillip Susi
     [not found] <fa.JbRGo0cQWncrcfKHmiNdvchsA50@ifi.uio.no>
     [not found] ` <fa.8qDECVaPIo7DWbjhQbyw6N5Infg@ifi.uio.no>
     [not found]   ` <fa.M4DOMggyrQmdTqekWSuw4xCxiTc@ifi.uio.no>
2007-10-25 23:27     ` Robert Hancock
     [not found] <e2e108260710260729x4603211cgb68d7434ce1e54e9@mail.gmail.com>
2007-10-26 14:40 ` Bart Van Assche
2007-10-26 15:09   ` Linus Torvalds
2007-10-26 15:34     ` Andrew Haley
2007-10-26 18:06       ` David Schwartz
2007-10-30 10:20         ` Andrew Haley
2007-11-02 15:29           ` Bart Van Assche
2007-11-02 15:38             ` Andrew Haley
2007-11-04 15:13               ` Bart Van Assche
2007-11-04 17:45                 ` Linus Torvalds
2007-11-04 17:58                   ` Andrew Haley
2007-11-04 18:06                   ` Bart Van Assche
2007-11-02 17:18             ` David Schwartz
2007-10-26 21:45     ` Giacomo Catenazzi
2007-10-26 22:24       ` Linus Torvalds
2007-10-26 15:27   ` Linus Torvalds
2007-10-26 16:28     ` Linus Torvalds
2007-10-26 17:07       ` Bart Van Assche
2007-10-26 17:12         ` Andrew Haley
2007-10-26 17:25           ` Linus Torvalds
2007-10-26 18:08         ` Alan Cox
2007-10-26 18:14           ` Linus Torvalds
2007-10-26 20:39           ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2007-10-28 18:19 linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874pgf1qih.fsf@willow.rfc1149.net \
    --to=sam@rfc1149.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox