Re: [PATCH 1/2] mm: move common segment checks to separate helper function (v6)

Christoph Hellwig
2007-03-12T08:27:25Z

On Mon, Mar 12, 2007 at 10:57:53AM +0300, Dmitriy Monakhov wrote:
> +/*
> + * Performs necessary checks before doing a write
> + *
> + * Adjust number of segments and amount of bytes to write.
> + * Returns appropriate error code that caller should return or
> + * zero in case that write should be allowed.
> + */
> +inline int generic_segment_checks(const struct iovec *iov,
> + unsigned long *nr_segs, size_t *count,
> + unsigned long access_flags)

Why isn't this static? Also I doubt that we want to inline this function.