public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Romosan <romosan@sycorax.lbl.gov>
To: Mike Galbraith <efault@gmx.de>
Cc: Jens Axboe <jens.axboe@oracle.com>,
	linux-kernel@vger.kernel.org, olaf@aepfle.de
Subject: Re: 2.6.19-rc1 regression: unable to read dvd's
Date: Thu, 12 Oct 2006 10:02:58 -0700	[thread overview]
Message-ID: <874pu94gcd.fsf@sycorax.lbl.gov> (raw)
In-Reply-To: <1160679627.7956.7.camel@Homer.simpson.net> (message from Mike Galbraith on Thu, 12 Oct 2006 19:00:27 +0000)

Mike Galbraith <efault@gmx.de> writes:

> On Thu, 2006-10-12 at 08:47 -0700, Alex Romosan wrote:
>> Jens Axboe <jens.axboe@oracle.com> writes:
>> 
>> > Argh damn, it needs this on top of it as well. Your second problem
>> > likely stems from that missing bit, please retest with this one applied
>> > as well.
>> >
>> > diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
>> > index e7513e5..bddfebd 100644
>> > --- a/drivers/ide/ide-cd.c
>> > +++ b/drivers/ide/ide-cd.c
>> > @@ -716,7 +716,7 @@ static int cdrom_decode_status(ide_drive
>> >  		ide_error(drive, "request sense failure", stat);
>> >  		return 1;
>> >  
>> > -	} else if (blk_pc_request(rq)) {
>> > +	} else if (blk_pc_request(rq) || rq->cmd_type == REQ_TYPE_ATA_PC) {
>> >  		/* All other functions, except for READ. */
>> >  		unsigned long flags;
>> >  
>> 
>> no more strange messages but, once again, i am not able to read movie
>> dvd's with the above patch applied.
>
> Hmm.  Xine still works fine here.
>
> I tried starting xine with no dvd in the drive for grins, and _without_
> this patch, I had to resort to SysRq-E to regain control of my box, and
> that still took quite a while.  I got no oops, but a zillion IO retries
> and sector blah messages.  DoSed me bigtime.  With this patch, I just
> got the expected can't open failure.

works fine for me too as i said in my next message (i initially forgot
to put the dvd in the drive). i guess this is what happens when i try
to test things before my morning espresso...

--alex--

-- 
| I believe the moment is at hand when, by a paranoiac and active |
|  advance of the mind, it will be possible (simultaneously with  |
|  automatism and other passive states) to systematize confusion  |
|  and thus to help to discredit completely the world of reality. |

  reply	other threads:[~2006-10-12 17:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-12  1:45 2.6.19-rc1 regression: unable to read dvd's Alex Romosan
2006-10-12  6:53 ` Jens Axboe
2006-10-12 10:28   ` Mike Galbraith
2006-10-12 14:13     ` Mike Galbraith
2006-10-12 12:09       ` Jens Axboe
2006-10-12 12:21         ` Jens Axboe
2006-10-12 14:44           ` Mike Galbraith
2006-10-12 13:07             ` Jens Axboe
2006-10-12 15:19           ` Alex Romosan
2006-10-12 15:23             ` Jens Axboe
2006-10-12 15:47               ` Alex Romosan
2006-10-12 19:00                 ` Mike Galbraith
2006-10-12 17:02                   ` Alex Romosan [this message]
2006-10-12 18:05                   ` Jens Axboe
2006-10-12 16:04               ` Alex Romosan
2006-10-12 16:51                 ` Jens Axboe
2006-10-13 14:40                   ` 2.6.19-rc1 (+ide-cd patches) regression: unable to rip cd Alex Romosan
2006-10-12 19:28           ` 2.6.19-rc1 regression: unable to read dvd's Olaf Hering
2006-10-12 20:20             ` Jens Axboe
2006-10-12 14:31         ` Mike Galbraith
2006-10-12 10:55 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874pu94gcd.fsf@sycorax.lbl.gov \
    --to=romosan@sycorax.lbl.gov \
    --cc=efault@gmx.de \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox