From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: <wei.fang@nxp.com>, <shenwei.wang@nxp.com>,
<xiaoning.wang@nxp.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>
Cc: <linux-imx@nxp.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: fec: Use page_pool_put_full_page when freeing rx buffers
Date: Thu, 19 Jan 2023 13:02:10 -0800 [thread overview]
Message-ID: <8756fac7-6107-57d3-c2fe-309dd8d3cf0a@intel.com> (raw)
In-Reply-To: <20230119043747.943452-1-wei.fang@nxp.com>
On 1/18/2023 8:37 PM, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
>
> The page_pool_release_page was used when freeing rx buffers, and this
> function just unmaps the page (if mapped) and does not recycle the page.
> So after hundreds of down/up the eth0, the system will out of memory.
> For more details, please refer to the following reproduce steps and
> bug logs. To solve this issue and refer to the doc of page pool, the
> page_pool_put_full_page should be used to replace page_pool_release_page.
> Because this API will try to recycle the page if the page refcnt equal to
> 1. After testing 20000 times, the issue can not be reproduced anymore
> (about testing 391 times the issue will occur on i.MX8MN-EVK before).
I had a look over other users in the kernel and it seems this bug hasn't
propagated anywhere that I see.
Thanks, for the fix, seems good to me.
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2023-01-19 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 4:37 [PATCH net] net: fec: Use page_pool_put_full_page when freeing rx buffers wei.fang
2023-01-19 21:02 ` Jesse Brandeburg [this message]
2023-01-23 10:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8756fac7-6107-57d3-c2fe-309dd8d3cf0a@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox