From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD6BA3431F5 for ; Fri, 7 Aug 2026 13:50:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786110666; cv=none; b=VGt79fBxiUeMNh5P04ycz8u+UCPPbCJ5KlNCUQAQI8FWyixBeSAL8ZZ92VFnXlnb3Wkcxt4L0kQIJ17I6zFKBCrQmwk+VhtWDHIXhyss73qbYVepnduG9ifj1MmXRrWZxNIHqDE5gMwwhc5Oa67znoyQ2kwmdcbaiuEopdkZBlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786110666; c=relaxed/simple; bh=MghTY2uUYmWnXdLFdMwje8FbaW6rcXme06jOy4Jc9tk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=W9CclhBXek4N9ydtvjzcnZ5PohZ7tv5TIr+UKjzhm0icCi9g+1om/slXDKNsPftySqUNZTCGdLhgYya7Bn8LEFkBRWvL3hPSFSf/A6mAgAFrnd6cSP1MgXSFvhW2sTXxbsL7WG6La2oWiHHQu1p3sKJ2Fj/wi4Ex0NOMdpfbpGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=SSNZam8j; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="SSNZam8j" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id CD0331A14AF; Fri, 7 Aug 2026 13:50:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 9F2AF603F0; Fri, 7 Aug 2026 13:50:49 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3410411C3792D; Fri, 7 Aug 2026 15:50:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1786110645; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=MghTY2uUYmWnXdLFdMwje8FbaW6rcXme06jOy4Jc9tk=; b=SSNZam8jBboxS+iOkaGHgKSks4KA6aIbV3qZLv9nV3TneNpyLn/Le56G3UihlNTBbudM06 Q7ONQ9rcZXb3urfe7d3qAOUAwDett+o5yUADTGDwMzEtIj29InXEkS5JOfXlbbdXT6qpKD a+n6aHSBPsA+KP1T4I6PLtplsmu+M8S96DgKfjWmMbuGneUQqBwTGP+4RvNwF6NC70GN0H oZYTKOBAmWEjYC1fRCwmE6Nt+3BfZd8+f37QYrFUZB2agSDWJQq28KwGginByVT/1DmpWM /pSutwRIvE0nfqkfB+Fjjrv0AA311X2nGa5VcPxNkgUXjrmBIo853YpNzV1vyw== From: Miquel Raynal To: Md Sadre Alam Cc: richard@nod.at, vigneshr@ti.com, tudor.ambarus@linaro.org, s-k6@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, varadarajan.narayanan@oss.qualcomm.com Subject: Re: [PATCH 2/2] mtd: spinand: winbond: add support for W25N01KW and W25N02LW In-Reply-To: <20260807064339.1632249-3-md.alam@oss.qualcomm.com> (Md Sadre Alam's message of "Fri, 7 Aug 2026 12:13:39 +0530") References: <20260807064339.1632249-1-md.alam@oss.qualcomm.com> <20260807064339.1632249-3-md.alam@oss.qualcomm.com> User-Agent: mu4e 1.12.12; emacs 30.2 Date: Fri, 07 Aug 2026 15:50:42 +0200 Message-ID: <875x1mca4t.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi Sadre, On 07/08/2026 at 12:13:39 +0530, Md Sadre Alam w= rote: > Add support for the Winbond W25N01KW and W25N02LW SPI-NAND > devices. > > The W25N01KW shares the same geometry, OOB layout, and ECC > status handling as the existing W25N01KV, while the W25N02LW > matches the existing W25N02KV/W25N02KW devices and reuses > their OOB layout and ECC status callback. > > Signed-off-by: Md Sadre Alam > --- Sashiko raises a point: - [Medium] The device ID `0x12, 0x22` for W25N02LW breaks the established pattern for Winbond 1.8V SPI NAND devices and is highly likely a typo for `0xb2, 0x22`. Can you please check? Thanks, Miqu=C3=A8l